libxul exports jpeg symbols when using bundled libjpeg

RESOLVED WORKSFORME

Status

Core Graveyard
Embedding: GRE Core
--
major
RESOLVED WORKSFORME
11 years ago
2 years ago

People

(Reporter: Philip Langdale, Unassigned)

Tracking

Bug Flags:
blocking1.9 ?

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

11 years ago
Unlike the bundled zlib and libpng, there is no symbol name rewriting done for libjpeg. This causes libxul to export those jpeg symbols which could be incorrectly used by an embedding application and lead to a crash.

As an example, I was getting crashes in galeon when visiting websites using jpeg favicons because the gdkpixbuf jpeg loader ended up using jpeg symbols from libxul instead of the system libjpeg. I worked around it locally by building --with-system-jpeg but the correct thing should be done in the bundled case.
Flags: blocking1.9?

Comment 1

11 years ago
With modern GCC that supports #pragma visibility (which includes all of our trunk compilers) this is not an issue. WFM
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → WORKSFORME
(Assignee)

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.