363379 - [FIX]Some flashes on the top and on the bottom of the page are missing.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P1)

Description

[Oleg Romashin (:romaxa)]

Install Flashplayer
STEPS LEADING TO PROBLEM: 
1. Go to the page http://www.105.net/index.php

EXPECTED OUTCOME:
Flashes should be dispalyed on the page

ACTUAL OUTCOME:
Some flashes on the top and on the bottom of the page are missing.


See screenshots.

Regression shows problem after this commits:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=cbiesinger%25web.de&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2005-09-21&maxdate=2005-09-22&cvsroot=%2Fcvsroot

https://bugzilla.mozilla.org/show_bug.cgi?id=1156

Comment 1

[Oleg Romashin (:romaxa)]

Attachment: Firefox 2.0 screen shot, looks ok.

Comment 2

[Oleg Romashin (:romaxa)]

Attachment: Mozilla Trunk screenshoot, white boxes instead flashplayer

Comment 3

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061210 Minefield/3.0a1
Reloaded a few times, but everything seems present.

Comment 4

[Ria Klaassen (not reading all bugmail)]

Ah well, it's a Linux bug :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Need testcase.  And I can't do anything with Linux bugs till January anyway.

Comment 6

[Andrew Schultz]

Attachment: testcase

With current trunk, the testcase displays blank instead of displaying the flash movie.

Comment 7

[Andrew Schultz]

Comment on attachment 248365 [details]
testcase

>      <param src="/swf/menu.swf" />

Actually, that's bogus, but it doesn't affect the testcase's display

Comment 8

[Andrew Schultz]

This regressed between linux seamonkey builds 2005-09-21-03-trunk and 2005-09-22-05-trunk, pointing to bug 1156.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Uh... what size did it display at, exactly?  This testcase doesn't specify a width/height, so ends up with a 0x0 plugin...  Is that not what we used to do?

Comment 10

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 248966 [details] [diff] [review]
Fix

perhaps instead of this change, the if from below (if (hasID)) should move up here and include an && !isSupportedClassID for easier to read code?

Comment 12

[Boris Zbarsky [:bzbarsky]]

Attachment: Yeah, indeeed

Comment 13

[Boris Zbarsky [:bzbarsky]]

Fixed.