If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsIScriptEventHandlerOwner tearoff for nsXULElement

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
I think nsIScriptEventHandlerOwner could be implemented as a tearoff.
It is called quite seldom (which was a bit surprising when I tested it).

This reduces the size of nsXULElement.

Patch coming.
(Assignee)

Comment 1

11 years ago
Created attachment 248261 [details] [diff] [review]
proposed patch

The interface is really used so rarely that this shouldn't cause perf regressions.
Assignee: general → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #248261 - Flags: superreview?(bugmail)
Attachment #248261 - Flags: review?(bugmail)
Attachment #248261 - Flags: superreview?(bugmail)
Attachment #248261 - Flags: superreview+
Attachment #248261 - Flags: review?(bugmail)
Attachment #248261 - Flags: review+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Comment 2

11 years ago
I'm about to open a BeOS-specific bug on this (we're stuck with gcc2.95) but thought I'd ask you if anyone can suggest an easy way to get this patch working for us as well:

We get compile errors complaining about mElement->FindPrototypeAttribute and mPrototype being protected in that context, reverting patch solves this, but does anyone know a nice way to fix this?

Comment 3

11 years ago
Reported bug 365118, if anyone can help.
You need to log in before you can comment on or make changes to this bug.