Closed
Bug 363506
Opened 19 years ago
Closed 19 years ago
Can not build nsDocumentViewer.cpp with --disable-printing
Categories
(Core :: Printing: Output, defect)
Core
Printing: Output
Tracking
()
RESOLVED
FIXED
People
(Reporter: andreas, Assigned: andreas)
Details
Attachments
(1 file)
|
1.22 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
This is a small regression from bug 361844. |mPrintEngine| is only defined if both printing and print preview is enabled, but the patch in the mentioned bug added a few lines accessing mPrintEngine without the needed defines.
|
Assignee | |
Comment 1•19 years ago
|
||
Trivial patch - add missing defines.
I don't think this file would build if someone combined --enable-printing with --disable-print-preview - a couple of places only check NS_PRINTING. Is that situation likely and something I should look at?
|
|
Assignee | |
Updated•19 years ago
|
Attachment #248311 -
Flags: review? → review?(roc)
Attachment #248311 -
Flags: superreview+
Attachment #248311 -
Flags: review?(roc)
Attachment #248311 -
Flags: review+
I don't think we should worry about that until/unless someone complains.
|
||
Comment 3•19 years ago
|
||
Checking in nsDocumentViewer.cpp;
/cvsroot/mozilla/layout/base/nsDocumentViewer.cpp,v <-- nsDocumentViewer.cpp
new revision: 1.505; previous revision: 1.504
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 4•19 years ago
|
||
My fault; sorry for the inconvenience.
You need to log in
before you can comment on or make changes to this bug.
Description
•