363605 - [FIX]Make computed style use GetStyle* methods, not GetStyleData

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P3)

Description

[Boris Zbarsky [:bzbarsky]]

See bug 360870 comments.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch

Sadly, this probably increases codesize some...

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Should we actually bother?  The existing methods aren't so bad -- I actually wasn't expecting you to do this; I'd forgotten about this case.

Comment 3

[Boris Zbarsky [:bzbarsky]]

The only reason to really do this, imo, is to eliminate this use of nsIFrame::GetStyleData() (only use, iirc) and one of the two remaining uses of nsStyleContext::GetStyleData().

Though I think I'd be pretty happy to leave most of those changes in (because they improve readability and type-safety) and just define the GetStyle* functions to be inlines calling something like GetStyleData for the time being.

Of course what I _really_ want to do somehow is make more of computed style table-driven... not sure how yet.

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

(In reply to comment #3)
> Though I think I'd be pretty happy to leave most of those changes in (because
> they improve readability and type-safety) and just define the GetStyle*
> functions to be inlines calling something like GetStyleData for the time being.

I think that sounds good.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch to that effect

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 249067 [details] [diff] [review]
Patch to that effect

r+sr=dbaron

Comment 7

[Boris Zbarsky [:bzbarsky]]

Checked in.