duplicate nsLivemarkService.getSiteURI in toolbar.xml

RESOLVED FIXED in Firefox 3 alpha1

Status

()

Firefox
Bookmarks & History
RESOLVED FIXED
11 years ago
8 years ago

People

(Reporter: Robert Sayre, Assigned: Robert Sayre)

Tracking

Trunk
Firefox 3 alpha1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

11 years ago
this will avoid startup component instantiation
(Assignee)

Comment 1

11 years ago
Created attachment 248440 [details] [diff] [review]
copy it over (also avoids URI creation, since we just want the spec)
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #248440 - Flags: review?(sspitzer)
(Assignee)

Updated

11 years ago
Depends on: 358946
Comment on attachment 248440 [details] [diff] [review]
copy it over (also avoids URI creation, since we just want the spec)

r=sspitzer
Attachment #248440 - Flags: review?(sspitzer) → review+
(Assignee)

Updated

11 years ago
Summary: duplication nsLivemarkService.getSiteURI in toolbar.xml → duplicate nsLivemarkService.getSiteURI in toolbar.xml
(Assignee)

Comment 3

11 years ago
Created attachment 248459 [details] [diff] [review]
add a comment in nsLivemarkService.js as suggested by sspitzer
Attachment #248440 - Attachment is obsolete: true
Attachment #248459 - Flags: review?(gavin.sharp)
(Assignee)

Comment 4

11 years ago
Created attachment 248460 [details] [diff] [review]
don't return on exception per gavin
Attachment #248459 - Attachment is obsolete: true
Attachment #248460 - Flags: review?(gavin.sharp)
Attachment #248459 - Flags: review?(gavin.sharp)
Comment on attachment 248460 [details] [diff] [review]
don't return on exception per gavin

>Index: browser/components/places/content/toolbar.xml

>+                
>+                // duplicate nsLivemarkService.getSiteURI to avoid instantiating

>+                if (siteURIString) {            
>+                  button.setAttribute("siteURI", siteURIString);
>                 }

uber-nits: remove the whitespace on the blank line, and drop the brackets around the single-line else clause?
Attachment #248460 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 6

11 years ago
Created attachment 248461 [details] [diff] [review]
nits fixed
Attachment #248460 - Attachment is obsolete: true
Attachment #248461 - Flags: review?(gavin.sharp)
(Assignee)

Updated

11 years ago
Attachment #248461 - Flags: review?(gavin.sharp)
(Assignee)

Comment 7

11 years ago
Created attachment 248462 [details] [diff] [review]
nits really fixed
Attachment #248461 - Attachment is obsolete: true
(Assignee)

Comment 8

11 years ago
Checking in toolkit/components/places/src/nsLivemarkService.js;
/cvsroot/mozilla/toolkit/components/places/src/nsLivemarkService.js,v  <--  nsLivemarkService.js
new revision: 1.5; previous revision: 1.4
done
Checking in browser/components/places/content/toolbar.xml;
/cvsroot/mozilla/browser/components/places/content/toolbar.xml,v  <--  toolbar.xml
new revision: 1.64; previous revision: 1.63
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
for completeness:

hatted with sayrer over irc about this patch.

this patch duplicates some code in the livemarks service into the toolbar code, so that on start up, we don't have to instantiate the livemarks service (and do all the work it will do on instantiation.

note to qa, this is on all platforms, but you need --enable-places-bookmarks to test it.
OS: Mac OS X 10.3 → All
Hardware: PC → All
(Assignee)

Updated

11 years ago
Target Milestone: --- → Firefox 3 alpha1
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.