363792 - tabbrowser destructor loops over array that's length of tabpanels rather than length of tabs

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

1. Open a new window
2. Open a new tab
3. Close the first tab
4. Close the window


          for (var i = 0; i < this.mTabListeners.length; ++i) {
            this.mPanelContainer.childNodes[i].webProgress.removeProgressListener(this.mTabFilters[i]);


Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/tabbrowser.xml ::  :: line 2078"  data: no]

I'll have to look at how this should really work.  I'm also curious about the various other loops that loop over listeners.  Do we just have to protect this one with an "if (whatever is not null)" like most of the rest of the loops?

Comment 1

[[e-mail]]

(In reply to comment #0)
>I'm also curious about the various other loops that loop over listeners.
I see none - they all loop over tabs (or their linked browsers).

Comment 2

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Attachment: patch

Comment 3

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checking in mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml;
/cvsroot/mozilla/xpfe/global/resources/content/bindings/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.171; previous revision: 1.170