363828 - Code coverage.

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Slavomir Katuscak]

Need to implement code coverage of NSS tests.

Comment 1

[Slavomir Katuscak]

Attachment: Adding -xprofile=tcov parameter.

If I want to measure coverage with TCOV tool, I need to compile code with -xprofile=tcov parameter. 

I haven't found any variable where I can set this parameter globally, so I use workaround from this patch where I added it to CC variable. I don't think this is the best way, but this is only way which works for me now. 

Is there any configuration file/variable where I can set this parameter and have all files compiled with it ? What should I modify to have the same for NSPR code ?

Comment 2

[Julien Pierre]

Slavo,

I thought we had other build options for Purify, but I didn't find anything either in coreconf. Your patch is correct and fine with me.

Comment 3

[Wan-Teh Chang]

Comment on attachment 260451 [details] [diff] [review]
Adding -xprofile=tcov parameter.

Slavo, if you add -xprofile=tcov to OS_CFLAGS instead,
does it still work?

Comment 4

[Slavomir Katuscak]

Wan-Teh, this is what I tried first, but it didn't work. After adding to CC it's OK. 

Comment 5

[Slavomir Katuscak]

Comment on attachment 260451 [details] [diff] [review]
Adding -xprofile=tcov parameter.

I have already finished scripts to test code coverage (it's on Sun CVS server, because there are many Sun specific paths and settings), so I would like to close this bug.

There is no more progress, so please review this patch as + if you are OK with it or help me to find better solution. Thanks.

Comment 6

[Wan-Teh Chang]

Comment on attachment 260451 [details] [diff] [review]
Adding -xprofile=tcov parameter.

r=wtc.

If the C++ compiler supports this flag, it would be nice
to add this to the CCC variable, too.

Comment 7

[Slavomir Katuscak]

Trunk:
Checking in SunOS5.mk;
/cvsroot/mozilla/security/coreconf/SunOS5.mk,v  <--  SunOS5.mk
new revision: 1.24; previous revision: 1.23
done

Branch:
Checking in SunOS5.mk;
/cvsroot/mozilla/security/coreconf/SunOS5.mk,v  <--  SunOS5.mk
new revision: 1.21.2.3; previous revision: 1.21.2.2
done

To comment #6:
C++ supports this flag, added also to CCC.