If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

" Add a new query" should be renamed

RESOLVED FIXED in Bugzilla 5.0

Status

()

Bugzilla
Whining
P2
trivial
RESOLVED FIXED
11 years ago
5 years ago

People

(Reporter: timeless, Assigned: sjoshi)

Tracking

({ue})

2.23.3
Bugzilla 5.0
Bug Flags:
approval +
blocking3.1.3 -
blocking3.0.3 -

Details

(URL)

Attachments

(1 attachment, 3 obsolete attachments)

5.04 KB, patch
Frédéric Buclin
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
the button says "add a new query", but it's not creating a new query. it's adding an existing query to an existing whine.

that's very different

Updated

11 years ago
Severity: normal → trivial
OS: Windows XP → All
Priority: -- → P5
Hardware: PC → All
(Reporter)

Comment 1

11 years ago
Created attachment 249576 [details] [diff] [review]
include search
Assignee: whining → timeless
Status: NEW → ASSIGNED
Attachment #249576 - Flags: review?

Comment 2

11 years ago
Comment on attachment 249576 [details] [diff] [review]
include search

>Index: template/en/default/whine/schedule.html.tmpl
>-        <input type="submit" value="Add a new query"
>+        <input type="submit" value="Include search"

This string appears elsewhere too, when you already have one query set. Both places must be fixed.
Attachment #249576 - Flags: review? → review-
(Reporter)

Comment 3

10 years ago
Created attachment 274887 [details] [diff] [review]
both instances
Attachment #249576 - Attachment is obsolete: true
Attachment #274887 - Flags: review?(wicked)

Comment 4

10 years ago
I don't think "Include search" is better. Personally, I find it as confusing. The question which comes to mind is "which search"?
Comment on attachment 274887 [details] [diff] [review]
both instances

Looks this bug was already partially fixed in bug 363912. But we now have a discrepancy between documentation and actual system. This discrepancy even affects some parts of the editwhines.cgi UI too! Not good. (Colin did say he didn't search for terms that were not changed.)

Term "query" needs to be changed in some other parts of editwhines.cgi page too. I count three places where the "query" word still appears in the introductory text and one in the "no searches available" text (line 330 of template/en/default/whine/schedule.html.tmpl).

I don't think term "Include search" is any better because it's now different from "Add a new event" and "Add a new schedule" terms. I would vote for using "Add a new search" everywhere, including docs.

>Index: docs/xml/using.xml
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/docs/xml/using.xml,v
>retrieving revision 1.70
>diff -u -r1.70 docs/xml/using.xml

Funny, a diff header for a file that doesn't have any changes.
Attachment #274887 - Flags: review?(wicked) → review-
Docs talk about buttons that are not available so something needs to done about this. Otherwise whine system UI is even more confusing to users than it already is. See also bug 287450.
Flags: blocking3.1.3?
Flags: blocking3.0.3?
Priority: P5 → P2
Target Milestone: --- → Bugzilla 3.0

Comment 7

10 years ago
trivial bugs aren't blockers. But yes, I agree that it would be nice to fix anything confusing about *any* part of Bugzilla's UI.
Flags: blocking3.1.3?
Flags: blocking3.1.3-
Flags: blocking3.0.3?
Flags: blocking3.0.3-

Comment 8

9 years ago
The Bugzilla 3.0 branch is now locked to security bugs and dataloss fixes only. This bug doesn't fit into one of these two categories and is retargetted to 3.2 as part of a mass-change. To catch bugmails related to this mass-change, use lts081207 in your email client filter.
Target Milestone: Bugzilla 3.0 → Bugzilla 3.2

Comment 9

9 years ago
Won't be taken for 3.2 either.
Target Milestone: Bugzilla 3.2 → ---
(Assignee)

Comment 10

5 years ago
Created attachment 667982 [details] [diff] [review]
Patch
Attachment #667982 - Flags: review?(LpSolit)

Updated

5 years ago
Attachment #274887 - Attachment is obsolete: true

Comment 11

5 years ago
Comment on attachment 667982 [details] [diff] [review]
Patch

As wicked said in comment 5, you must also fix the text in the description at the top of the page as well as the name of the button in the documentation, see section 5.13.3.
Attachment #667982 - Flags: review?(LpSolit) → review-
(Assignee)

Comment 12

5 years ago
Created attachment 671222 [details] [diff] [review]
Patch-v2

Fixed other areas of schedule.html.tmpl and in documentation too.
Attachment #667982 - Attachment is obsolete: true
Attachment #671222 - Flags: review?(LpSolit)

Comment 13

5 years ago
Comment on attachment 671222 [details] [diff] [review]
Patch-v2

Looks good. r=LpSolit
Attachment #671222 - Flags: review?(LpSolit) → review+

Updated

5 years ago
Assignee: timeless → joshi_sunil
Flags: approval+
Target Milestone: --- → Bugzilla 5.0

Comment 14

5 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified docs/en/xml/using.xml
modified template/en/default/whine/schedule.html.tmpl
Committed revision 8434.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.