364058 - [cocoa-cairo] css length unit 'ex' doesn't work on 10.3.9

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Stefan [:stefanh]]

No matter how I use the ex length unit since the cairo switch it doesn't seem to work. This is also the reason for the broken Help content reported in bug 361510. I'll attach a testcase in a sec.

Comment 1

[Stefan [:stefanh]]

Attachment: Testcase, margin-left value

Comment 2

[Stefan [:stefanh]]

jftr: Mano couldn't reproduce it when I asked him, so I assume this is 10.3.9-only.

Comment 3

[Stan Shebs]

I can confirm that the example loses with my recent (Dec 6, time to update) trunk build on 10.3.9, and wins on 10.4.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Taking, but I don't have the 10.3. I'll need the help.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 250092 [details] [diff] [review]
Patch rv1.0

This patch gets the near value in 10.4. The metrics value and the text image height does not much. But I don't know the reason.

Comment 7

[Stefan [:stefanh]]

Comment on attachment 250092 [details] [diff] [review]
Patch rv1.0

Testcase works for me with this patch applied (10.3.9, building with 10.3.0 sdk).

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to comment #7)
> (From update of attachment 250092 [details] [diff] [review])
> Testcase works for me with this patch applied (10.3.9, building with 10.3.0
> sdk).
> 

Thank you for your test!

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.