364071 - Fix nsTextTransformer API so that aWordLenResult will become an output-only parameter again (in Get[Next|Prev]Word)

Status: RESOLVED WONTFIX

(Core :: Layout, defect)

Description

[Uri Bernstein]

Spun off from bug 363732.

Background:
In bug 36163 the aWordLenResult parameter to nsTextTransformer::GetPrevWord and nsTextTransformer::GetNextWord, which was originally an output parameter, was overloaded and became an I/O parameter.
Its value on input (if it's not -1) now indicates an offset in the content where scanning for the next/prev word should stop.

This is confusing, as this parameter now holds a different type of value on input and output.

Plan for fixing this:
Add aBeginOffset and aEndOffset parameters to nsTextTransformer::Init(), that would mark the range inside the content for the transformer to work with. Store these values in data members (mBeginOffset, mEndOffset), and use them where currently the input values of aWordLenResult is used. -1 will be allowed for aEndOffset, signifying "end of content".

Sounds reasonable?

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The new textframe code makes nsTextTransformer obsolete, so let's not do this.

Comment 2

[Uri Bernstein]

WONTFIX, then.