There is a "show votes for this bug" link when the bug has no votes

RESOLVED FIXED in Bugzilla 3.0

Status

()

Bugzilla
Creating/Changing Bugs
--
trivial
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: timeless, Assigned: reed)

Tracking

2.23.3
Bugzilla 3.0
Bug Flags:
approval +

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Related actions                                  
                                                                               * View Bug Activity                            
   Note                                                                        * Format For Printing                          
                                                                               * XML                                          
   You need to log in before you can comment on or make changes to this bug.   * Clone This Bug                               
                                                                             Votes: 0                                         
                                                                               * Show votes for this bug                      
                                                                               * Vote for this bug                            
                                                                                                   

Note that "Vote for this bug" is distinct. showing me votes for this bug after telling me there are none is just plain silly.

Updated

11 years ago
Severity: normal → trivial
Keywords: ue
OS: Mac OS X 10.3 → All
Hardware: Macintosh → All
Summary: why is there a show votes for this bug if the bug has no votes? → There is a "show votes for this bug" link when the bug has no votes
(Assignee)

Comment 1

11 years ago
Created attachment 249661 [details] [diff] [review]
patch - v1

Only show the link if there are > 0 votes.
Assignee: create-and-change → reed
Status: NEW → ASSIGNED
Attachment #249661 - Flags: review?(bugzilla-mozilla)

Comment 2

11 years ago
Comment on attachment 249661 [details] [diff] [review]
patch - v1

>Index: template/en/default/bug/edit.html.tmpl

>+              [% IF bug.votes > 0 %]

CHANGE ON COMMIT: Just use 'IF bug.votes'.
Attachment #249661 - Flags: review?(bugzilla-mozilla) → review+

Updated

11 years ago
Flags: approval?
Whiteboard: [Change-on-commit]

Comment 3

11 years ago
Comment on attachment 249661 [details] [diff] [review]
patch - v1

You are basically creating an <ul> with only one <li> element in case there are no bugs, which is not great from a mark-up perspective (but it works I think).

Comment 4

11 years ago
s/no bugs/no bug votes/
makes sense to me.
Flags: approval? → approval+
(Assignee)

Comment 6

11 years ago
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.95; previous revision: 1.94
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Change-on-commit]
Target Milestone: --- → Bugzilla 3.0
You need to log in before you can comment on or make changes to this bug.