364262 - white rect appears behind the "gear" action pop-up menu when it is clicked.

Status: RESOLVED FIXED

(Camino Graveyard :: Preferences, defect)

Description

[Sean Murphy]

Inside either of the two sheets that are displayed from within the privacy preference pane (Show Cookies… or Edit Exceptions List…) there is a white artifact drawn around the shortcut actions pop-up button (bottom left corner).

Steps to Reproduce:
1) Open Preferences.
2) Switch to the Privacy pane.
3) Click the Show Cookies or Edit Exceptions List buttons.
4) Press the gear pop-up in the bottom left and leave it selected.

Actual Results: A white rect is drawn behind the button.  (10.4.8+: control+scroll to zoom in and see it better).  A screenshot of this is attached.

Expected Results: Behave like the pop-up buttons inside the bookmark manager and not display anything around the button when pressed.

Comment 1

[Sean Murphy]

Attachment: Screenshot

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I wonder if it's always done that?

Comment 3

[froodian (Ian Leue)]

No.  1.1a1 is the first release to have this problem... which means it was probably something I did. :(

Comment 4

[froodian (Ian Leue)]

This is because the border for those elements extends slightly beyond the button.  I changed it for ease in positioning, but looks like the border should shrink down again.

Comment 5

[froodian (Ian Leue)]

Attachment: New Privacy.nib

I resized the bounding boxes, then manually repositioned them until the final result had the same placement as the originals (by checking the build results with a ruler).

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 249065 [details]
New Privacy.nib

There's still one white pixel along the entire left side of the button in each sheet :(  (There is no such line in 1.0.x, so unless there is clipping in 1.0.x on 10.4, this is not a 10.3-10.4 discrepancy....)  Other than that, the layout is fine.

Also, how difficult is it to port the grey-button-hack from Edit Permissions to Edit Cookies, so that Esc works in that sheet, too.

Comment 7

[froodian (Ian Leue)]

Attachment: New Privacy.nib

This fixes the remaining white pixel.

The grey escape button is cool, but unfortunately causes an ugly white flash for me.  I've taken it out for now - we should discuss a good way to keep this functionality in another bug.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Comment on attachment 249084 [details]
New Privacy.nib

r=ardissone

Sucks about the hidden button :(

Comment 9

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

> The grey escape button is cool, but unfortunately causes an ugly white flash
> for me.  I've taken it out for now - we should discuss a good way to keep this
> functionality in another bug.

Now bug 364320.

Comment 10

[Stuart Morgan]

Comment on attachment 249084 [details]
New Privacy.nib

sr=smorgan, but someone should double-check that it doesn't stomp bug 330534 (it seemed to still work for me).

Comment 11

[froodian (Ian Leue)]

Checked in on trunk and MOZILLA_1_8_BRANCH (and yeah, that other fix still worked for me too)