364275 - some texts in Account Setting->Security dialog need LABEL_FOR set

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Lynn Monsanto]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1) Gecko/20060601 Firefox/2.0 (Ubuntu-edgy)
Build Identifier: version 3 alpha 1 (20061218)

Each page in the Account Wizard (Identity, Server Information, etc.) has static text above components. For example, the Server Information page has the following text above the "Incoming Server" label and text field:

"Enter the name of your incoming server (for example, "mail.example.net")."  Assistive technologies, like Orca, should speak the static text as a label for the text field below it. So, the LABEL_FOR property needs to be set for the static text and the LABELLED_BY property needs to be set for the text field.

Reproducible: Always

Steps to Reproduce:
1. Start Thunderbird 3, and launch the Account Wizard.
2. Start AT-POKE and expand the Account Wizard subtree
3. Examine the static text nodes, LABEL_FOR is not set for any of them

Actual Results:  
See above.

Expected Results:  
See above.

Comment 1

[Lynn Monsanto]

Not having LABEL_FOR set for static text is a problem in all dialogs that have more than one block of static text. See: "Offline & Disk Space" page in the the Account Settings dialog. 

Comment 2

[Evan Yan]

(In reply to comment #0)
> text above components. For example, the Server Information page has the
> following text above the "Incoming Server" label and text field:
> 
> "Enter the name of your incoming server (for example, "mail.example.net")." 

"Incoming Server" is the label of the text field and it does have LABEL_FOR property for the text field.

Comment 3

[Lynn Monsanto]

This bug is still a major problem that makes the Account Settings dialog (and other dialogs) very confusing for people with disabilities. For example, in the Security page, the following text does not have LABEL_FOR assigned:

1. "To send and receive signed..."
2. "Use this certificate to digitally..."
3. "Use this certificate to encrypt..."
4. "Default encryption settings when..."

This means that assistive technologies cannot speak/Braille the appropriate text for the component that has focus.

For example, an assisive technology should only speak "Use this certificate to encrypt..." when the Encryption text field has keyboard focus.

Comment 4

[Evan Yan]

(In reply to comment #3)
> 1. "To send and receive signed..."
this is just a description, no need LABEL_FOR I think.

> 2. "Use this certificate to digitally..."
> 3. "Use this certificate to encrypt..."
I'll post a patch for these two.

> 4. "Default encryption settings when..."
I don't think we set LABEL_FOR for a label to control a radiogroup right now.
> 

anyway, please note the lack of LABEL_FOR is just bug for some individual text, not a common problem of all static text.

Comment 5

[Evan Yan]

Attachment: add control attribute for two labels

Comment 6

[Asaf Romano (gone)]

Comment on attachment 251045 [details] [diff] [review]
add control attribute for two labels

I'm not a mail/ peer.

Comment 7

[Scott MacGregor]

Comment on attachment 251045 [details] [diff] [review]
add control attribute for two labels

This looks pretty safe for the branch too Evan.

Comment 8

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381