Closed Bug 364286 Opened 18 years ago Closed 18 years ago

Code in Classification->products() is suboptimal

Categories

(Bugzilla :: Bugzilla-General, defect)

Product:
Bugzilla
Component:
Bugzilla-General
Version:
2.23.3
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: LpSolit)

References

Details

(Keywords: perf)

Attachments

(1 file)

patch, v1
844 bytes, patch
mkanat
: review+
Details | Diff | Splinter Review 
We should use the much more efficient Product->new_from_list() method. This code is among others used in query.cgi. This could help making this page faster.
Attached patch patch, v1 — — Splinter Review 

        Attachment #249058 -
        Flags: review?(bugzilla-mozilla)

    
    

    
  
Comment on attachment 249058 [details] [diff] [review]
patch, v1

Obviously correct.

        Attachment #249058 -
        Flags: review?(bugzilla-mozilla) → review+

    
  
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+

    
    

    
  
Checking in Bugzilla/Classification.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Classification.pm,v  <--  Classification.pm
new revision: 1.11; previous revision: 1.10
done

Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: