364287 - toolkit/viewPartialSource.js onLoadPartialSource window may not have arguments

Status: RESOLVED WORKSFORME

(Toolkit :: View Source, defect)

Description

[C. Greg Hagerty]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1) Gecko/20061010 Firefox/2.0

Better check
 if (window.arguments) {
before 
   if (window.arguments[3] == 'selection'...}

Reproducible: Sometimes

Steps to Reproduce:
Happened after reloading chrome after using.
Actual Results:  
Just an error

Comment 1

[Steve England [:stevee]]

Reporter, do you still see this problem with the latest Firefox 2? If not, can you please close this bug as WORKSFORME. Thanks!

Comment 2

[C. Greg Hagerty]

As long as arguments[2] and arguments[3] are defined when onLoadViewPartialSource is called this is okay.   I don't know why this would not be the case, only that it has happened to me after reloading chrome. But not recently. Ideally, it would be good to check whether there are are indeed arguments before accessing them, in the unlikely event that there aren't any.  But in that case the resulting error would be appropriate, thus it worksforme.