Closed
Bug 364320
Opened 18 years ago
Closed 10 years ago
Esc won't close the cookies sheets in the Privacy prefPane
Categories
(Camino Graveyard :: Preferences, defect)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: alqahira, Unassigned)
Details
(Keywords: regression)
Esc used to work to close the Cookie Permissions sheet (but not the Cookies sheet, oddly) because there was a hidden button to handle Esc. Unfortunately, this now causes an unsightly white flash when using Esc on 10.4, so Ian removed the hidden button in bug 364262. We should discuss a way to restore the Esc functionality in these sheets.
Comment 1•18 years ago
|
||
We should be overriding |cancel:| somewhere in the responder chain (most likely the prefpane class), now that we're 10.3+.
Comment 2•18 years ago
|
||
I'm not sure about that. We do override |cancel:| for the prefpane, but can we do so for the sheet as well? Where would it be?
Comment 3•18 years ago
|
||
If the prefpane is set to be the sheet's delegate, it will get a chance to handle cancel: if the sheet doesn't. We'd just have to do something like if ([cookieSheet isVisible]) { hide it } else { do normal stuff }
Updated•17 years ago
|
Target Milestone: Camino1.6 → ---
Comment 4•17 years ago
|
||
Privacy:Show Cookies… Privacy:Edit Exceptions List… don't respond to esc, but I think they should. Privacy:Edit Keychain Exclusions…, proposed in bug 354975 and as implemented there, also doesn't respond to esc. Appearance:Fonts:Advanced… doesn't respond to esc either. Web Features:Edit Pop-up Exceptions List… DOES respond to esc. Good job! Finally, Security:Show Certificates doesn't respond to esc, but it shows a separate window, not a sheet. Why? And why doesn't the button name in the prefpane have an ellipsis?
Reporter | ||
Comment 5•17 years ago
|
||
(In reply to comment #4) > Web Features:Edit Pop-up Exceptions List… DOES respond to esc. Good job! Add is the default button here, so we were able to map Esc to Done. > Finally, Security:Show Certificates doesn't respond to esc, but it shows a > separate window, not a sheet. Why? And why doesn't the button name in the > prefpane have an ellipsis? Because there's no further action required in the new window (see also Privacy's "Open Keychain Access").
Comment 6•17 years ago
|
||
I understand why Open Keychain Access is like that, but I don't see how Show Certificates is any different than Show Cookies….
Reporter | ||
Comment 7•17 years ago
|
||
You have to take action to get out of the sheet.
Comment 8•10 years ago
|
||
This bug has been buried in the graveyard and has not been updated in over 5 years. It is probably safe to assume that it will never be fixed, so resolving as WONTFIX. [Mass-change filter: graveyard-wontfix-2014-09-24]
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•