Within a few weeks gecko will remove support for building without cairo gfx. Camino already doesn't support non-cairo gfx. We have a lot of clutter in cocoa widgets because of supporting non-cairo gfx, I think it is time to remove it.
Created attachment 249143 [details] [diff] [review] fix v1.0
This is already messing with enn in 178513.
By messing with enn, I mean supporting non-cairo gfx is problematic for him.
Comment on attachment 249143 [details] [diff] [review] fix v1.0 > $(MAC_LCPPSRCS) \ >+ nsNativeThemeCocoa.cpp \ > $(NULL) This should use tabs, since it's a makefile. > EXTRA_DSO_LDOPTS += \ > $(MOZ_UNICHARUTIL_LIBS) \ > $(TK_LIBS) \ > $(call EXPAND_LIBNAME_PATH,gkgfx,$(DEPTH)/gfx/src) \ > $(MOZ_COMPONENT_LIBS) \ > $(NULL) > >-ifdef MOZ_ENABLE_CAIRO_GFX > EXTRA_DSO_LDOPTS += -lthebes >-endif Can this just go inline in the list above, rather than being added after? >-// Depending on whether we're on cairo, and if accessibility is on, we support different @protocols The accessibility part of this comment should stay. r=smorgan; I won't miss it.
Comment on attachment 249143 [details] [diff] [review] fix v1.0 In addition to what smorgan wrote: >Index: Makefile.in >-ifdef MOZ_ENABLE_CAIRO_GFX > REQUIRES += thebes cairo These can be added to the REQUIRES list above.
Comment on attachment 249143 [details] [diff] [review] fix v1.0 rs=pink
Created attachment 249144 [details] [diff] [review] fix v1.0.1 This is what I plan to land, fixes based on review comments.
landed on trunk