Closed Bug 364381 Opened 14 years ago Closed 13 years ago

Year selection in minimonth is limited to 7 years

Categories

(Calendar :: Calendar Views, enhancement)

x86
Windows XP
enhancement
Not set

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: omarb.public, Assigned: Fallen)

Details

Attachments

(2 files, 2 obsolete files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1) Gecko/20061010 Firefox/2.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.1) Gecko/20061010 Firefox/2.0

Today is 19/12/2006. If I want to go to 31/01/2018 using mini-calendar I need to perform many wasting of time steps:
1) I select the last year choice from year drop down menu- 2010
2) I select the last year choice- 2014
3) I select 2018
----------------
There should be a possibility to scroll the year list

Reproducible: Always
Summary: Year selection in mini-calendar is limited to 7 years- no possibility to scroll the list → Year selection in minimonth is limited to 7 years
Attached patch Give minimonth more years - v1 (obsolete) — Splinter Review
This patch takes care of it, also giving both month and year pickers a bit more padding. Does anyone have some more ideas on how we can improve the minimonth month/year popup? I can put some of that into this bug, otherwise we could create a spinoff (if it doesn't already exist).
Assignee: nobody → bugzilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #268117 - Flags: review?(michael.buettner)
Attached image Screenshot - v1
Attachment #268118 - Flags: ui-review?(christian.jansen)
(In reply to comment #1)

> Does anyone have some more ideas on how we can improve the minimonth
> month/year popup? I can put some of that into this bug, otherwise we could
> create a spinoff (if it doesn't already exist)


The screenshot shows what I was asking for. So for me it looks fine :-)
Attached patch Give minimonth more years - v2 (obsolete) — Splinter Review
With the old patch, there were some issues that showed negative years when you switch to year 1. Also some small CSS changes.

BTW, I'd need someone with a mac to check and see if it looks ok there.
Attachment #268117 - Attachment is obsolete: true
Attachment #268207 - Flags: review?(michael.buettner)
Attachment #268117 - Flags: review?(michael.buettner)
Comment on attachment 268118 [details]
Screenshot - v1

Looks good to me.
UI Review = +
Attachment #268118 - Flags: ui-review?(christian.jansen) → ui-review+
Comment on attachment 268207 [details] [diff] [review]
Give minimonth more years - v2

>+      <method name="moveYears">
>+        <parameter name="direction"/>
>+        <body><![CDATA[
In order to follow the style rules of this file, please move the cdata tag to the next line. The same applies to the ending tag, of course.

>+            // Update the year popup
>+            var years = this.kYearList;
>+            var current = this.mEditorDate.getFullYear();
>+            var offset;
>+
>+            switch (direction) {
>+              case "reset":
>+                var middleyear = years[parseInt(years.length / 2)].getAttribute("value");
I wouldn't use parseInt() here, instead I'd use Math.floor(). Admittedly, the result is the same, but IMHO floor() is the cleaner solution.

The rest of the patch look fine to me. Nice little feature, thanks for the patch. r=mickey with the style nit mentioned above fixed.
Attachment #268207 - Flags: review?(michael.buettner) → review+
Whiteboard: [checkin needed after 0.5]
Nits fixed
Attachment #268207 - Attachment is obsolete: true
Attachment #268792 - Flags: review+
Checked in on HEAD and MOZILLA_1_8_BRANCH

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed after 0.5]
Target Milestone: --- → 0.7
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.5pre) Gecko/20070702 Calendar/0.7pre
Status: RESOLVED → VERIFIED
Verified with Lightning 2007070203
You need to log in before you can comment on or make changes to this bug.