Closed Bug 364388 Opened 18 years ago Closed 17 years ago

Import fails on repeating events with modified individual occurrences

Categories

(Calendar :: Import and Export, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ssitter, Unassigned)

References

Details

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/20061219 Calendar/0.4a1

Import fails on repeating events with modified individual occurrences

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Create repeating event in storage calendar
3. Modify one occurrence of this event e.g. by changing start time or title
4. Export the entire calendar to .ics file (iCalendar format)
5. Delete all occurrences and events from storage calendar
6. Import the .ics file created in step 4 into storage calendar


Actual Results:
Import fails with the message '1 items failed to import. The last error was: 2147500037'. After confirming this message the repeating event is shown as created in step 2. The modifications done in step 3 are lost.


Expected Results:
The repeating event and the modified occurrence are imported and displayed correctly.


Additional Information:
When opening the exported .ics file as new calendar everything works as expected.

The (shortened) .ics file in question looks like:

    BEGIN:VEVENT
    UID:dd62c3eb-75c5-4e5d-869f-83f8fc8b33b7
    SUMMARY:Sample Repeating Event
    RRULE:FREQ=DAILY;COUNT=5;INTERVAL=1
    DTSTART;TZID=/mozilla.org/20050126_1/Europe/Berlin:20061225T130000
    DTEND;TZID=/mozilla.org/20050126_1/Europe/Berlin:20061225T150000
    END:VEVENT

    BEGIN:VEVENT
    UID:dd62c3eb-75c5-4e5d-869f-83f8fc8b33b7
    SUMMARY:Modified Occurrence of Sample Repeating Event
    RECURRENCE-ID;TZID=/mozilla.org/20050126_1/Europe/Berlin:20061227T130000
    DTSTART;TZID=/mozilla.org/20050126_1/Europe/Berlin:20061227T100000
    DTEND;TZID=/mozilla.org/20050126_1/Europe/Berlin:20061227T120000
    END:VEVENT
    
It looks like the importer fails to recognize the RECURRENCE-ID that marks the second VEVENT as a modified occurrence of the first VEVENT. Then the importer tries to import two events with the same UID and fails. The ics provider handles this correct.
To me, this just seems like another vote for unifying the importer and provider's ICS parsing.
Dupe of bug 354578?
Stefan,
Could you attempt to replicate this using today's nightly (once it's finished)?
mvl landed the great ICS parsing unification (bug 364841) and this in theory _should_ be fixed.
Retest with Sunbird/0.4a1 (2007011105) after Bug 364841 being fixed:

Import no longer fails. But the displayed result is not as expected: 

Instead of the repeating event + one modified occurrence the unmodified repeating event is shown as created in step 2 from Comment #0 --> This is a regression because this used to work with the ics provider in Sunbird/0.4a1 (2007011003).
(In reply to comment #4)

> Import no longer fails. But the displayed result is not as expected: 
> 
> Instead of the repeating event + one modified occurrence the unmodified
> repeating event is shown as created in step 2 from Comment #0 --> This is a
> regression because this used to work with the ics provider in Sunbird/0.4a1
> (2007011003).
> 
I filed a new bug for this (bug 368490) in order to have an updated bug description. --> Resolve FIXED for this one?


Successfully retested with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.2pre) Gecko/20070208 Calendar/0.4a1.

Fixed by checkin for Bug 364841 and Bug 368490.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.