364397 - Bookmarks under the chevron menu do nothing when activated

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Bookmarks under the chevron menu do nothing when activated, this is happening (Er, not happening) because there are no command/click event handlers set on its popup. Fixing this sort-of-requires making places toolbar.xml view depend on browser-places.js (BookmarksEventHandler in particular).

Comment 1

[Asaf Romano (gone)]

Ignore most of comment 0, the issue here is events bubbling which is the case for menuitems in this popup - the listeners set in browser.xul are not "expecting" that.

Comment 2

[Asaf Romano (gone)]

Attachment: patch

Comment 3

[(not reading, please use [e-mail] instead)]

Comment on attachment 249962 [details] [diff] [review]
patch

r=sspitzer.  it took me a minute to see the core of this fix is event.target -> event.originalTarget.

Comment 4

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js 1.16

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv