364426 - tree in places based history sidebar doesn't have contiguous vertical lines (like in firefox 2)

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[(not reading, please use [e-mail] instead)]

places based history sidebar doesn't have contiguous vertical lines (like in firefox 2)

hard to explain, but here comes some screen shots.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: fx 2 screen shot

Comment 2

[(not reading, please use [e-mail] instead)]

Attachment: fx 3 (trunk) screen shot on windows

Comment 5

[Sylvain Pasche]

Attachment: fix hasNextSibling

I didn't find a way to compute the index of a child node, relative to its parent. That could have optimized things, like in the example below:

var childIndex = this._visibleElements[aRow].childIndex; // hypothetical
var parent = this._visibleElements[aRow].parent;
if (!parent)
    return false;
return childIndex < parent.childCount - 1;


For reference, here's the code which draws the vertical lines:

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/layout/xul/base/src/tree/src/nsTreeBodyFrame.cpp&rev=1.335&mark=3122-3139#3122

Comment 6

[Asaf Romano (gone)]

Comment on attachment 285623 [details] [diff] [review]
fix hasNextSibling

r=mano

Comment 7

[Reed Loden [:reed]]

Checking in browser/components/places/content/treeView.js;
/cvsroot/mozilla/browser/components/places/content/treeView.js,v  <--  treeView.js
new revision: 1.21; previous revision: 1.20
done

Comment 8

[Marcia Knous [:marcia]]

This looks fine on Windows using  Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103004 Minefield/3.0a9pre. However, not sure what is expected on Mac. I don't see the same vertical lines on Mac, but when I checked Firefox 2, I don't see them either. This was filed against all OS's so just checking to make sure I am not missing something.

Comment 9

[Brian Polidoro]

It might be Windows only.  One of the dupe bugs was filed against linux.  That's why I set OS to All.  But looking back now I see that the screenshot given in that bug looks like Windows. 

Comment 10

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.0;
en-US; rv:1.9a9pre) Gecko/2007103004 Minefield/3.0a9pre.

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv