[FIX][reflow branch] Right hand side of empty select is slightly cut off

RESOLVED FIXED in mozilla1.9alpha6

Status

()

Core
Layout: Form Controls
P3
trivial
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Martijn Wargers (zombie), Assigned: bz)

Tracking

({regression, testcase})

Trunk
mozilla1.9alpha6
regression, testcase
Points:
---
Bug Flags:
blocking1.9 +
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

12 years ago
See upcoming testcase, this regressed between 2006-12-07 and 2006-12-08, so probably a regression from the reflow branch landing.

As you know, I have 'fat' scrollbars.

I'll post screenshots of what I see with the testcase, before and after the reflow branch.

Also the right part of the select drop down arrow isn't repainted when a popup menu has been over it. It seems to only paint the 16px wide part that's the default size of the scrollbar, normally (and mine are 32px).
(Reporter)

Comment 1

12 years ago
Created attachment 249276 [details]
testcase

Only the first select (the empty select) suffers from the "slightly cut off" part of the bug.
But both selects suffer from the painting bug when a popup menu has been over the right hand side of the selects.
(Reporter)

Comment 2

12 years ago
Created attachment 249279 [details]
Screenshots
So the sizing issue here is that options have padding.  So when we have an option we end up with a total width of padding plus width of the scrollbar.

When we do _not_ have an option, we end up with a total width equal to the scrollbar... but we're trying to fit in the scrollbar width _and_ a nonbreaking space in there.
Created attachment 252007 [details] [diff] [review]
This should fix it
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #252007 - Flags: superreview?(dbaron)
Attachment #252007 - Flags: review?(dbaron)
OS: Windows XP → All
Priority: -- → P3
Hardware: PC → All
Summary: [reflow branch] Right hand side of empty select is slightly cut off → [FIX][reflow branch] Right hand side of empty select is slightly cut off
Target Milestone: --- → mozilla1.9alpha
(Reporter)

Comment 5

11 years ago
+  // of our display fram plus a scrollbar.  This can happen, eg, if the
Small spelling error: fram should be frame.
(Reporter)

Updated

11 years ago
Flags: blocking1.9?
Flags: blocking1.9? → blocking1.9+
Target Milestone: mozilla1.9alpha1 → mozilla1.9alpha6
Comment on attachment 252007 [details] [diff] [review]
This should fix it

s/fram /frame /

r+sr=dbaron
Attachment #252007 - Flags: superreview?(dbaron)
Attachment #252007 - Flags: superreview+
Attachment #252007 - Flags: review?(dbaron)
Attachment #252007 - Flags: review+
Fixed.  not sure how to test it...
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.