364521 - Need a bundleIdentifier attribute in nsILocalFileMac

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P2)

Description

[Asaf Romano (gone)]

It should be possible to retrieve the identifier of a bundle via nsILocalFileMac.

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Comment 2

[Mark Mentovai]

Comment on attachment 249285 [details] [diff] [review]
patch

Check the return value of CFStringReftoUTF8 - either assign it in to rv or use an NS_ASSERTION.

Comment 3

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 249285 [details] [diff] [review]
patch

+[scriptable, uuid(748f3ffe-27d9-4402-9de9-494badbeebf4)]
 interface nsILocalFileMac : nsILocalFile

is this meant for the branch as well? If so, doesn't the interface name need to change to reflect the interface change? I seem to recall some bizarre naming ritual around the branch.

sr=pink

Comment 4

[Asaf Romano (gone)]

(In reply to comment #3)
> (From update of attachment 249285 [details] [diff] [review] [edit])
> +[scriptable, uuid(748f3ffe-27d9-4402-9de9-494badbeebf4)]
>  interface nsILocalFileMac : nsILocalFile
> 
> is this meant for the branch as well?

Nope.

Comment 5

[Asaf Romano (gone)]

Attachment: as checked in

mozilla/xpcom/io/nsILocalFileMac.idl 1.8
mozilla/xpcom/io/nsLocalFileOSX.cpp 1.47