36455 - unable to go to url with port but without http://

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P3)

Description

[sairuh (rarely reading bugmail)]

this might be due to the docshell changes --so pls dup or reassign as needed.
found this using 2000.04.19.16 on linux and winNT (will check Mac when it's
available). wasn't a problem in this morning's build.

to repro:
1. enter bubblegum.mcom.com:4321 (exactly)into the Location textfield.
2. hit enter key.

result: page won't load (for expected results, see smoketest 19 re: HTTP
headers). on linux, get the following error in the console:

JavaScript error: 
 line 0: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIBrowserInstance.loadUrl]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://navigator/content/navigator.js :: BrowserLoadURL :: line 982"  data:
no]

note: this is *not* a problem if
a. http:// is added to the url, or,
b. bubblegum.mcom.com is entered (no prt specified)

Comment 1

[Sean Richardson]

Cc-ing [e-mail], who wrote a patch for a similar problem 
with a protocol specified for bug 31854, "[4.xP] Unable to open 
www.foo.com:/some/dir (note colon)".

Comment 2

[Andreas Otte]

I will look into this.

Comment 3

[Andreas Otte]

I don't think this ever worked. http:// is only added if there is no colon in
the string or the colon comes after a /. bubblegum.mcom.com:4321 violates that
rule.

Maybe we can check in this case if the scheme we falsly identified is a known
one or not and act on that.

Comment 4

[WD]

Yeah, there are several web pages that I know of that use port numbers.  (such
as mine:  dormcam.mine.nu:8080 )

I would think that mozilla would put the "http://" in there automatically when
you hit enter, but it doesn't.

Comment 5

[Andreas Otte]

*** Bug 37453 has been marked as a duplicate of this bug. ***

Comment 6

[Andreas Otte]

Attachment: patch to fix the problem

Comment 7

[verah (gone)]

Reassigning as per Don Melton

Comment 8

[Radha on family leave (not reading bugmail)]

Andreas, I'll try your patch today. But you may want to take Jud's approval 
before checking in, since he is inheriting travis's bugs.

Comment 9

[Radha on family leave (not reading bugmail)]

andreas, your diffs look ok to me. valeski now owns docshell.

Comment 10

[Andreas Otte]

fix checked in

Comment 11

[Tom Everingham]

verified:
NT 2000051609