Closed
Bug 364586
Opened 19 years ago
Closed 4 years ago
nsXmlRpcCLient.js conversion to base64 is slow
Categories
(Core :: XML, defect)
Core
XML
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: gilles+mozilla, Assigned: samuel)
Details
Attachments
(1 file, 2 obsolete files)
|
4.15 KB,
patch
|
Details | Diff | Splinter Review |
Currently converting a stream to a base64-encoded string is quite slow, about 3.5 minutes for a 700K file.
The following patch will make the conversion 6 to 7 times faster.
|
Reporter | |
Comment 1•19 years ago
|
||
Attachment #249349 -
Flags: superreview?
Attachment #249349 -
Flags: review?
|
||
Comment 2•19 years ago
|
||
Can't use just use btoa(), now that bug 326854 is fixed?
|
|
Reporter | |
Comment 3•19 years ago
|
||
Indeed. I will try that tomorrow.
But this patch might still be used for 1.8 branch since bug 326854 is trunk only.
|
|
Reporter | |
Comment 4•19 years ago
|
||
|btoa| is now used for encoding and |atob| used for deconding as well
Attachment #249349 -
Attachment is obsolete: true
Attachment #249427 -
Flags: superreview?
Attachment #249427 -
Flags: review?
Attachment #249349 -
Flags: superreview?
Attachment #249349 -
Flags: review?
|
||
Comment 5•19 years ago
|
||
You need to provide a requestee for your review requests, otherwise they'll likely be missed. I think samuel@sieb is a good choice.
|
|
Reporter | |
Updated•19 years ago
|
Attachment #249427 -
Flags: review? → review?(samuel)
|
Assignee | |
Comment 6•18 years ago
|
||
I've switched it to use binary streams so we don't have to worry about nulls. Please test it out and let me know how it works.
Assignee: mozbug → samuel
Attachment #249427 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #249427 -
Flags: superreview?
Attachment #249427 -
Flags: review?(samuel)
|
||
Updated•16 years ago
|
QA Contact: ashshbhatt → xml
|
||
Comment 7•4 years ago
|
||
The XML-RPC component was removed (I think before Firefox 3).
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•