Open Bug 364586 Opened 14 years ago Updated 11 years ago
Xml Rpc CLient .js conversion to base64 is slow
Currently converting a stream to a base64-encoded string is quite slow, about 3.5 minutes for a 700K file. The following patch will make the conversion 6 to 7 times faster.
Can't use just use btoa(), now that bug 326854 is fixed?
Indeed. I will try that tomorrow. But this patch might still be used for 1.8 branch since bug 326854 is trunk only.
|btoa| is now used for encoding and |atob| used for deconding as well
You need to provide a requestee for your review requests, otherwise they'll likely be missed. I think samuel@sieb is a good choice.
I've switched it to use binary streams so we don't have to worry about nulls. Please test it out and let me know how it works.
You need to log in before you can comment on or make changes to this bug.