Currently converting a stream to a base64-encoded string is quite slow, about 3.5 minutes for a 700K file. The following patch will make the conversion 6 to 7 times faster.
Created attachment 249349 [details] [diff] [review] Patch for trunk
Can't use just use btoa(), now that bug 326854 is fixed?
Indeed. I will try that tomorrow. But this patch might still be used for 1.8 branch since bug 326854 is trunk only.
Created attachment 249427 [details] [diff] [review] Updated trunk patch |btoa| is now used for encoding and |atob| used for deconding as well
You need to provide a requestee for your review requests, otherwise they'll likely be missed. I think samuel@sieb is a good choice.
Attachment #249427 - Flags: review? → review?(samuel)
Created attachment 274381 [details] [diff] [review] new patch using binary streams I've switched it to use binary streams so we don't have to worry about nulls. Please test it out and let me know how it works.
You need to log in before you can comment on or make changes to this bug.