364593 - Partial Update from 2 to 2.0.0.1 breaks Firefox

Status: RESOLVED DUPLICATE of bug 340535

(Toolkit :: Application Update, defect)

Description

[Damian Shaw [Quan]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

I loaded up Firefox 2, it started a software update. The update stopped and gave me the error message:

"Software Update Failed" - Name of the Error Window

"One or more files could not be updated. Please make sure all other applications are closed and that you have permission to modify these files, and then restart Firefox to try again." - Main Text of the Window

"OK" - My total number of options.

After pressing OK, it then proceeded to try a partial update again and come up with the same error message. (I pressed OK about 4 / 5 times before giving up).

I fixed the problem by using IE to download Firefox 2.0.0.1 from getfirefox.com.

Reproducible: Couldn't Reproduce

Steps to Reproduce:
Was unable to reproduce after fixing it.

Comment 1

[Carsten Book [:Tomcat]]

If possible, could you attach the updates.xml file from your Firefox Application Directory and the update/last-update log (its in the update folder) to this bug ?

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

(In reply to comment #0)
You don't say anything about applying this advice: "Please make sure all other
applications are closed and that you have permission to modify these files ...". 

Some things that can cause this: 
 * your Windows account is not an administrator
 * another Windows user is using Firefox via Fast User switching
 * you use an app to keep Firefox in memory for quicker launch
 * spyware/malware prevents Firefox from exiting

Are you willing to reinstall Firefox 2 to try to debug this ?

Comment 3

[Damian Shaw [Quan]]

Attachment: Update.xml as requested

Comment 4

[Damian Shaw [Quan]]

Attachment: Last update log as requested

Comment 5

[Damian Shaw [Quan]]

(In reply to comment #2)
> (In reply to comment #0)
> You don't say anything about applying this advice: "Please make sure all other
> applications are closed and that you have permission to modify these files
> ...". 
> 
> Some things that can cause this: 
>  * your Windows account is not an administrator
>  * another Windows user is using Firefox via Fast User switching
>  * you use an app to keep Firefox in memory for quicker launch
>  * spyware/malware prevents Firefox from exiting
> 
> Are you willing to reinstall Firefox 2 to try to debug this ?
> 

Sure I'd be willing to do that, but let me go through your list in order first:

*My Windows account is administrator
*There was no other user logged on to windows
*I don't use any app which interferes or 'enhances' Firefox in anyway
*There is no spyware/malware on my computer, I'm a technically competent user and have virus scanners / spyware scanners and avoid software and websites which would give you such problems.

Just give me a set of instructions and I'll try to my best to do what you need me to do.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

The update.log is very short - there is an UNEXPECTED_ERROR on the very first file (AccessibleMarshal.dll). There are quite a lot of ways of hitting that (see the toolkit/mozapps/update hits at http://lxr.mozilla.org/mozilla1.8/search?string=UNEXPECTED_ERROR), so I'm not sure how to proceed.

Comment 7

[Rob Campbell [:rc] (:robcee)]

copying seth on this...

Comment 8

[Benjamin Smedberg]

If you have accessibility enabled, it's possible that Windows or an accessibility app is holding onto that DLL after firefox itself has shut down.

Comment 9

[Damian Shaw [Quan]]

(In reply to comment #8)
> If you have accessibility enabled, it's possible that Windows or an
> accessibility app is holding onto that DLL after firefox itself has shut down.
> 

How could I check if this is enabled or check if this has happened?

Comment 10

[Ben Turner (not reading bugmail, use the needinfo flag!)]

From the log it's either of these:

http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/update/src/updater/updater.cpp#733
http://lxr.mozilla.org/mozilla1.8/source/toolkit/mozapps/update/src/updater/updater.cpp#750

Seems that the size of the unmar'd patch isn't the same as the size claimed by the mar header. Bad mar?

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

Damien, is the bug reproducable ? Try uninstalling Firefox 2.0.0.1, then reinstall 2.0 from 
  http://releases.mozilla.org/pub/mozilla.org/firefox/releases/2.0/win32/en-GB/
and try to update.

Comment 12

[Damian Shaw [Quan]]

(In reply to comment #11)
> Damien, is the bug reproducable ? Try uninstalling Firefox 2.0.0.1, then
> reinstall 2.0 from 
>   http://releases.mozilla.org/pub/mozilla.org/firefox/releases/2.0/win32/en-GB/
> and try to update.
> 

Nope can't reproduce it sorry, must be some odd quirk that almost never happens I guess.

Comment 13

[Carsten Book [:Tomcat]]

(In reply to comment #8)
> If you have accessibility enabled, it's possible that Windows or an
> accessibility app is holding onto that DLL after firefox itself has shut down.
> 

Could this be related to https://bugzilla.mozilla.org/show_bug.cgi?id=340535#c8 ?

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's the same problem. So duping.