364605 - Error 'ArrayOfEvents[0] has no properties' in unifinder.js

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/20061221 Calendar/0.4a1

Error 'ArrayOfEvents[0] has no properties' in unifinder.js

Steps to Reproduce:
1. Start Sunbird with clean profile
2. Select filter 'Events in the Next 7 Days' in unifinder
3. Switch to month view
4. Create non-all-day event that lasts from yesterday to tomorrow
5. Drag and drop event to previous week
6. Edit event and change the start time
7. Drag and drop event to initial date

Actual Results:
JavaScript console shows the following error
  Error: ArrayOfEvents[0] has no properties
  Source File: chrome://calendar/content/unifinder.js 
  Line: 377
Apart from that everything seems to work fine.

Comment 1

[Joey Minta]

js> new Array().concat(null).length
1

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/calendar/resources/content/unifinder.js&rev=1.142&mark=208-209#200

Comment 2

[Joey Minta]

Attachment: check for null

I can't tell you how much I want to trash all this code and re-write it.

This patch checks to make sure we got a real event back, before adding it to the array.

Comment 3

[Matthew (lilmatt) Willis]

Comment on attachment 250763 [details] [diff] [review]
check for null

r=lilmatt

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 250763 [details] [diff] [review]
check for null

r2=mvl

Comment 5

[Joey Minta]

patch checked in.

Comment 6

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20070112 Calendar/0.4a1