While testing a recent partner build, Tracy found this in the popup exceptions list: "scheme:http" - status: "allow" The cause is that I wrapped a call to getCharPref() in the component we use in partner extensions to populate the popup exceptions, and so now it continues on to the next part where it tries to split an empty string and add items to the exceptions list. A simple fix is to return if the pref is empty/unset. Patch on the way.
Created attachment 249375 [details] [diff] [review] Don't add to popups whitelist if pref is empty ...wrapped in a try/catch block, is what I meant to say in the last comment.
Attachment #249375 - Flags: review?(rhelmer)
Attachment #249375 - Flags: review?(rhelmer) → review+
Checking in PartnerBookmarks.js; /mofo/repackage/common/xpi-generator/components/Attic/PartnerBookmarks.js,v <-- PartnerBookmarks.js new revision: 126.96.36.199; previous revision: 188.8.131.52 done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.