Partner extension creates an extraneous item in the popup exceptions list

VERIFIED FIXED

Status

()

Firefox
Build Config
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: thunder, Assigned: thunder)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
While testing a recent partner build, Tracy found this in the popup exceptions list:

"scheme:http" - status: "allow"

The cause is that I wrapped a call to getCharPref() in the component we use in partner extensions to populate the popup exceptions, and so now it continues on to the next part where it tries to split an empty string and add items to the exceptions list.

A simple fix is to return if the pref is empty/unset.  Patch on the way.
(Assignee)

Comment 1

11 years ago
Created attachment 249375 [details] [diff] [review]
Don't add to popups whitelist if pref is empty

...wrapped in a try/catch block, is what I meant to say in the last comment.
Attachment #249375 - Flags: review?(rhelmer)
Attachment #249375 - Flags: review?(rhelmer) → review+
(Assignee)

Comment 2

11 years ago
Checking in PartnerBookmarks.js;
/mofo/repackage/common/xpi-generator/components/Attic/PartnerBookmarks.js,v  <--  PartnerBookmarks.js
new revision: 1.1.2.3; previous revision: 1.1.2.2
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.