364621 - Partner extension creates an extraneous item in the popup exceptions list

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[Dan Mills [:thunder]]

While testing a recent partner build, Tracy found this in the popup exceptions list:

"scheme:http" - status: "allow"

The cause is that I wrapped a call to getCharPref() in the component we use in partner extensions to populate the popup exceptions, and so now it continues on to the next part where it tries to split an empty string and add items to the exceptions list.

A simple fix is to return if the pref is empty/unset.  Patch on the way.

Comment 1

[Dan Mills [:thunder]]

Attachment: Don't add to popups whitelist if pref is empty

...wrapped in a try/catch block, is what I meant to say in the last comment.

Comment 2

[Dan Mills [:thunder]]

Checking in PartnerBookmarks.js;
/mofo/repackage/common/xpi-generator/components/Attic/PartnerBookmarks.js,v  <--  PartnerBookmarks.js
new revision: 1.1.2.3; previous revision: 1.1.2.2
done