364682 - Updater should stop any download if the app version/update channel etc change (eg after manual app install)

Status: RESOLVED DUPLICATE of bug 536547

(Toolkit :: Application Update, defect)

Description

[Keith Nichol]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1

I was downloading 2.0.0.1 using the check for updates option. It crashed and unfortunately I didn't save the error screen, please don't shoot me. I then downloaded 2.0.0.1 from the Mozilla site and updated manually. All seemed well, except I now have the check for updates displaying "downloading Firefox 2.0.0.1..." This happens even after several cold boots. If I open the download manager there is nothing there. Nothing that I can recognise in Task Manager.

Reproducible: Always

Steps to Reproduce:
1. I cannot really reproduce, it's stuck....
2.
3.




Just gone back to the check for updates option

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

The crash should not have happened, but sounds like we have no way to debug that. The resulting problem is that the updater doesn't reset itself after a manual install of the new version. There should be check before the d/l of the update is resumed (on app start). Comparing the complete serviceURL would cover all the possibilities of version, channel, OS etc changing.

I'm confirming this bug on the basis of previous reports in support forums and so on. 

Keith, the fix for you is to close Firefox down, then remove from the install dir (probably C:\Program Files\Mozilla Firefox\) the files active-update.xml and updates.xml, and the directory called updates.

Comment 2

[Keith Nichol]

(In reply to comment #1)
> The crash should not have happened, but sounds like we have no way to debug
> that. The resulting problem is that the updater doesn't reset itself after a
> manual install of the new version. There should be check before the d/l of the
> update is resumed (on app start). Comparing the complete serviceURL would cover
> all the possibilities of version, channel, OS etc changing.
> 
> I'm confirming this bug on the basis of previous reports in support forums and
> so on. 
> 
> Keith, the fix for you is to close Firefox down, then remove from the install
> dir (probably C:\Program Files\Mozilla Firefox\) the files active-update.xml
> and updates.xml, and the directory called updates.
> 

Thanks for following up so promptly. At first I thought it had fixed itself, but  it started the download again. I cleaned off those files and directory and all is now well. I've cycled the check for updates button several times and it is behaving as it should.

I really appreciate what you are doing in supporting such a great product.

Cheers Keith 

Comment 3

[Robert Strong (they/them - no direct email)]

We check if an earlier version is being downloaded as of 3.5 and bug 536547 will check if it is the same version for release builds. Duping to bug 536547 which should solve this for the reported problem though it won't fix it for nightly builds.