364693 - replace "make all" with "convert ..."

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect, P4)

Description

[timeless]

steps: 1. watch justdave run checksetup.pl

actual results:
... and run contrib/recode.pl to make all
the data in your database into UTF-8.

expected results: use the word 'convert' instead of 'make'

(or maybe 'make sure all the data in your database is encoded as UTF-8')

Comment 1

[timeless]

Attachment: reorder and clarify warnings

Comment 2

[Frédéric Buclin]

Max should be the one reviewing this patch.

Comment 3

[Max Kanat-Alexander]

Comment on attachment 276391 [details] [diff] [review]
reorder and clarify warnings

The "this will affect every single table" applies both to the UTF-8 conversation and to recode.

Comment 4

[Gervase Markham [:gerv]]

Bug still present, but now in template/en/default/setup/strings.txt.pl .

Gerv

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

:gerv- is this still a worthwhile bug to fix?  If so, and if this makes a good first bug, can you link to the code, how to reproduce this problem, and what an ideal fix looks like?  This should have a mentor assigned as well.

Comment 6

[Gervase Markham [:gerv]]

Code file given in comment 4; this is just a typo fix. It doesn't need a mentor.

Gerv

Comment 7

[shrvan]

Hi , Is this still a valid bug ? how do I go about resolving it? (PS. its my first time here)

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

:gerv, can you help Shrvan find the code, get setup, and determine how to post a patch.  I know you said this bug didn't need a mentor, but someone has to help point Shrvan in the right direction.

Comment 9

[Andre Klapper]

(In reply to Joel Maher ( :jmaher) from comment #8)
> :gerv, can you help Shrvan find the code

See bug 364693 comment 6.

> get setup

See https://bugzilla.readthedocs.io/en/latest/installing/ and https://github.com/bugzilla/bugzilla

> and determine how to post a patch.

See https://wiki.mozilla.org/Bugzilla:Developers

Comment 10

[Dylan Hardison [:dylan] (he/him)]

(In reply to shrvan from comment #7)
> Hi , Is this still a valid bug ? how do I go about resolving it? (PS. its my
> first time here)

Hey shrvan! The easiest way to get setup would be to get our code from github (https://github.com/bugzilla/bugzilla)
and follow along the readme to get a local copy running:

https://github.com/bugzilla/bugzilla/blob/master/README.rst#for-developers

Meanwhile, I'm not sure about this bug. The topic is different from the applied patch, and I don't know if it is still valid but I'll triage and get back to you shortly.

Comment 11

[Firefox Bug Husbandry Bot]

Removing good-first-bug keyword because team does not have bandwidth to mentor at the moment.

Comment 12

[Shrey Gupta]

Hi, I would like to start contributing. This is my first bug so can you please guide me on how to fix this bug. Thanks

Comment 13

[Andre Klapper]

Welcome Shrey and thanks a lot for your interest! Do you have a specific question which is not already answered by previous comments?

Comment 14

[Shrey Gupta]

Is this bug in the mozilla-firefox build or do I have to separately set up the bugzilla developer build?

Comment 15

[Shrey Gupta]

Sir, I have corrected the bug and sent a pull request. Kindly verify and let me know it there is any problem. Thank you

Comment 16

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Attachment: GitHub Pull Request

Comment 17

[Shrey Gupta]

Has this bug been resolved?

Comment 18

[Dave Miller [:justdave]]

(In reply to Shrey Gupta from comment #17)

Has this bug been resolved?

Yes.

Committed to the 5.2 branch on January 18, 2020:
https://github.com/bugzilla/bugzilla/commit/75cfe2ae0359320ea16809eb547db43bcef2d16b