Closed
Bug 364754
Opened 18 years ago
Closed 18 years ago
ActiveX control doesn't build with MSVC8 Express
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benjamin, Assigned: benjamin)
Details
Attachments
(1 file)
|
3.51 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
But it could, with a few code changes and an emulation library which I'm going to stick in the mozillabuild system. This mainly fixes problems with the older version of the ATL headers which have for-loop scoping issues, and an issue with a MSVC-specific header which isn't needed.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #249466 -
Flags: review?(dbaron)
Comment on attachment 249466 [details] [diff] [review] Hack around scoping, and use better header, rev. 1 >+#pragma conform(forScope, show) Did you mean to take this out? (It's only in the second file.) I'll trust you on the header -- hopefully it won't break somebody else. r=dbaron
Attachment #249466 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
Fixed on trunk.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•