ActiveX control doesn't build with MSVC8 Express

RESOLVED FIXED

Status

Firefox Build System
General
RESOLVED FIXED
12 years ago
3 months ago

People

(Reporter: Benjamin Smedberg, Assigned: Benjamin Smedberg)

Tracking

Trunk
x86
Windows NT

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
But it could, with a few code changes and an emulation library which I'm going to stick in the mozillabuild system. This mainly fixes problems with the older version of the ATL headers which have for-loop scoping issues, and an issue with a MSVC-specific header which isn't needed.
(Assignee)

Comment 1

12 years ago
Created attachment 249466 [details] [diff] [review]
Hack around scoping, and use better header, rev. 1
Attachment #249466 - Flags: review?(dbaron)
Comment on attachment 249466 [details] [diff] [review]
Hack around scoping, and use better header, rev. 1

>+#pragma conform(forScope, show)

Did you mean to take this out?  (It's only in the second file.)

I'll trust you on the header -- hopefully it won't break somebody else.

r=dbaron
Attachment #249466 - Flags: review?(dbaron) → review+
(Assignee)

Comment 3

12 years ago
Fixed on trunk.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

3 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.