36483 - AddressBook: DE: Import window title is hardcoded.

Status: VERIFIED DUPLICATE of bug 39036

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P3)

Description

[John Burns]

Bug : The Import window title in the "Address Book" Componant of Netscape 6 is 
hardcoded and cannot be localised for the Beta build.

Steps to repro:
1. Launch The "Address Book" Componant of Netscape 6.
2. Click on the "File" ("Datei") Menu.
3. Click on "Import" ("Importieren")

The title of the window that shows is "Open File". This should be localisable.

Comment 1

[lchiang]

Scott - does this really belong to you?

Comment 2

[scottputterman]

it looks like this is happening in AB backend code.  reassigning to chuang.

Comment 3

[selmer (gone)]

Target M17.

Comment 4

[chuang]

The "Import..." has switching to use import utility.  "Open File" has changed to 
"Select Address Book File".  It should put in properties file and use 
GetBundleString() in importDialog.js.

Comment 5

[rchen]

The problem isn't really gone away. I found the following lines with strings 
hardcoded in importDialog.js. Please move them to properties file:

filePicker.chooseInputFile( "Select settings file", filePicker.eAllFiles, null, 
null);
filePicker.chooseDirectory( "Select mail directory");
filePicker.chooseDirectory( "Select address book directory");
filePicker.chooseInputFile( "Select address book file", filePicker.eAllFiles, 
null, null);
				
										
						

Comment 6

[leger]

Putting on [nsbeta2-] radar.  

Comment 7

[rchen]

If we don't fix this bug, we won't be able to localize the title of the window. 
The fix is simple and reliable.

Comment 8

[msanz]

removing nsbeta2-. rchen can fix it and give the file to the owner ffor  
checkin. deal?

Comment 9

[rchen]

tonyr, do you prefer me to fix it or you can do it? I will give you the patch to 
checkin if I fix it. 

Comment 10

[leger]

Putting on [nsbeta2+] radar.

Comment 11

[tonyr]

Just waiting on a simple code review before checking in the fix.

Comment 12

[tonyr]

Fix checked in.

Comment 13

[leger]

Adding verifyme keyword.

Comment 14

[rchen]

I reopen the bug because...

The strings are in importMsg.properties. But after I localized them in unicode. 
They are not displayed correctly. Here is the sample data, I replace "directory" 
with two Japanese:

ImportSelectAddrFile=Select address book \u30a2\u30c9

Comment 15

[leger]

Per today's PDT mtg, moving from [nsbeta2+] to [nsbeta2-]

Localizabiity bug to be fixed before UI freeze.

Comment 16

[tonyr]

What does "not displayed correctly" mean?  The strings are loaded from the 
.properties file using nsIStringBundle.GetStringFromName.  There's really nothing 
else I can do with it.

Comment 17

[rchen]

Ftang, can you help tonyr? I believe it is very close, It might be just the 
unicode handling issue. 

Comment 18

[Frank Tang]

remove [nsbeta2-]
>Localizabiity bug to be fixed before UI freeze.
We are shipping a Japanese nsbeta2 the same day we ship English nsbeta2. 
Localizability problem have to be fixed before nsbeta2.

Comment 19

[Frank Tang]

The problem is the current code use nsFileSpecWithUI as file picker while we 
should move to use nsIFilePicker instead. The nsFileSpecWithUI interface does 
not support unicode. 

Comment 20

[Frank Tang]

reassign back to [e-mail]
tonyr- please switch your nsIFileSpecWithUI code to nsIFilePicker. Currently, 
most of the code in mozilla are already switch to nsIFilePicker except some code 
in mailnews and addressbook.

Please talk to [e-mail] and [e-mail] about how to switch the 
code from nsIFileSpecWithUI to nsIFilePicker.

The problem code which using nsIFileSpecWithUI is under 
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/import/resources/co
ntent/importDialog.js

There are 3 places in this javascript file have this problem
/mailnews/import/resources/content/importDialog.js, line 453 -- filePicker = 
filePicker.QueryInterface(
Components.interfaces.nsIFileSpecWithUI);
/mailnews/import/resources/content/importDialog.js, line 526 -- filePicker = 
filePicker.QueryInterface(
Components.interfaces.nsIFileSpecWithUI);
/mailnews/import/resources/content/importDialog.js, line 617 -- filePicker = 
filePicker.QueryInterface(
Components.interfaces.nsIFileSpecWithUI);

law, can you help ?

Comment 21

[Bill Law]

Here's a link to an example of JS code that calls nsIFilePicker:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/ucth/resources/helperApp
Launcher.js#134

Comment 22

[Frank Tang]

Bill- thanks. some of tonyr's code need to pass nsIFileSpec to native code. How 
can we get nsIFileSpec from nsIFilePicker (indirectly) ?

Comment 23

[Bill Law]

nsIFile and nsILocalFile have methods/attributes that get the path name.  That
might be what you need for calling native code, but you can also use it to
construct an nsIFileSpec.  There's code in nsStreamTransfer.cpp that does that,
I think.

Comment 24

[Jay Patel [:jay]]

Putting on [nsbeta2-] radar. Not critical to beta2. 

Comment 25

[tonyr]

As long as I can convert an nsIFile to an nsIFileSpec in JS, this should be easy 
to fix.

Comment 26

[tonyr]

*** This bug has been marked as a duplicate of 39036 ***

Comment 27

[Håkan Waara]

tonyr: are you sure this is a duplicate? please verify/reopen this bug.

Comment 28

[Håkan Waara]

Hello world? That other bug's summary is "Linux filepicker or file:// view
doesn't show hidden directories or files". I can't see how that is supposed to
be a duplicate of this?

Comment 29

[timeless]

2000-09-27 15:12:19 [e-mail] changed bug 39036 short_desc:
Import addressbook open dialog doesn't show hidden directories or files => 
Linux filepicker doesn't show hidden directories or files.

Comment 30

[fenella]

.