Firefox fails to build when using the Windows Vista SDK

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: craig.hawco, Unassigned)

Tracking

Trunk
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061223 Firefox/3.0a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061223 Firefox/3.0a2pre

widget/src/windows/nsKeyboardLayout.cpp fails to compile when using the Windows Vista SDK. Apparently winable.h has been removed, and the declarations moved into winuser.h. 

Reproducible: Always
(Reporter)

Comment 1

12 years ago
Created attachment 249525 [details] [diff] [review]
Proposed patch

Include winuser.h, then check if we've picked up the WINABLEAPI define. If not, we must be using an older SDK and include winable.h.
Craig: please ask for review from one of the owner/peers listed at http://www.mozilla.org/owners.html#win32-based-gfx-and-widget by using "Edit Attachment", setting the review dropdown to "?" and entering their email address in the textbox.
Status: UNCONFIRMED → NEW
Component: General → General
Ever confirmed: true
Product: Firefox → Core
QA Contact: general → general
Version: unspecified → Trunk
Assignee: nobody → win32
Component: General → Widget: Win32
QA Contact: general → ian
(Reporter)

Updated

12 years ago
Attachment #249525 - Flags: review?(neil)
Comment on attachment 249525 [details] [diff] [review]
Proposed patch

I see the MSDN online documentation has already been updated with the new include, although I'm not about to download the Vista SDK to try this out.
Attachment #249525 - Flags: review?(neil) → review+

Comment 4

12 years ago
Fixed on trunk.

/mozilla/widget/src/windows/nsKeyboardLayout.cpp 3.9
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.