364831 - Firefox fails to build when using the Windows Vista SDK

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Craig Hawco]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061223 Firefox/3.0a2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a2pre) Gecko/20061223 Firefox/3.0a2pre

widget/src/windows/nsKeyboardLayout.cpp fails to compile when using the Windows Vista SDK. Apparently winable.h has been removed, and the declarations moved into winuser.h. 

Reproducible: Always

Comment 1

[Craig Hawco]

Attachment: Proposed patch

Include winuser.h, then check if we've picked up the WINABLEAPI define. If not, we must be using an older SDK and include winable.h.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Craig: please ask for review from one of the owner/peers listed at http://www.mozilla.org/owners.html#win32-based-gfx-and-widget by using "Edit Attachment", setting the review dropdown to "?" and entering their email address in the textbox.

Comment 3

[[e-mail]]

Comment on attachment 249525 [details] [diff] [review]
Proposed patch

I see the MSDN online documentation has already been updated with the new include, although I'm not about to download the Vista SDK to try this out.

Comment 4

[Peter Kasting]

Fixed on trunk.

/mozilla/widget/src/windows/nsKeyboardLayout.cpp 3.9