364835 - current bug number should be filled in in "to bugs" input box to simplify tagging

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement)

Description

[Declan Naughton]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20061222 Minefield/3.0a2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20061222 Minefield/3.0a2pre

The current bug number should be filled in in "to bugs" input box to simplify tagging.

Reproducible: Always

Steps to Reproduce:
1.login and view https://landfill.bugzilla.org/prodpatches/show_bug.cgi?id=415
2.examine the tagging interface at the bottom
3.

Actual Results:  
Tagging would be much simpler if the current bug number was filled in in the "to bugs" input box.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

Pre-fill the box with the bug's id if there is one.

Comment 2

[Olav Vitters]

Comment on attachment 249672 [details] [diff] [review]
patch - v1

>Index: template/en/default/global/per-bug-queries.html.tmpl

>-        <input type="text" name="bug_ids" size="12" maxlength="80">
>+        <input type="text" name="bug_ids" size="12" maxlength="80"
>+         [%- " value=\"$bug.bug_id\"" IF bug %]>

This assumes bug is only used by show_bug.cgi. It is also used by buglist.cgi (others as well). E.g. try buglist.cgi?bug_id=1,2 (or any search). The code will prefill the tag to '2'.

Think the best option is having a different variable.

Further, with show_bug.cgi?id=1&id=2&format=multiple it would be nice if it would prefill the list with "1,2" :-) (not a requirement.. having it work for a single bug is fine).

Comment 3

[Reed Loden [:reed]]

Attachment: patch - v2

Use "bugids" as a var name and implement request.

Comment 4

[Frédéric Buclin]

I don't like patch v2. The logic should be done in show_bug.cgi.

Comment 5

[Reed Loden [:reed]]

Attachment: patch - v3

Implement LpSolit's way.

Comment 6

[Olav Vitters]

Comment on attachment 249723 [details] [diff] [review]
patch - v3

>Index: template/en/default/global/per-bug-queries.html.tmpl

>-        <input type="text" name="bug_ids" size="12" maxlength="80">
>+        <input type="text" name="bug_ids" size="12" maxlength="80"
>+         [%- " value=\"$bugids\"" IF bugids %]>

#   Failed test '(en/default) template/en/default/global/per-bug-queries.html.tmpl has unfiltered directives:
#   91:- " value=\"$bugids\"" IF bugids 
# --ERROR'
#   in t/008filter.t at line 131.

Comment 7

[Reed Loden [:reed]]

Attachment: patch - v4

Add directive to filterexceptions.pl.

Comment 8

[Reed Loden [:reed]]

Checking in show_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/show_bug.cgi,v  <--  show_bug.cgi
new revision: 1.50; previous revision: 1.49
done
Checking in template/en/default/global/per-bug-queries.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/per-bug-queries.html.tmpl,v  <--  per-bug-queries.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.92; previous revision: 1.91
done