All users were logged out of Bugzilla on October 13th, 2018

current bug number should be filled in in "to bugs" input box to simplify tagging

RESOLVED FIXED in Bugzilla 3.0

Status

()

--
enhancement
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: piratepenguin, Assigned: reed)

Tracking

2.23.3
Bugzilla 3.0
Bug Flags:
approval +

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20061222 Minefield/3.0a2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a2pre) Gecko/20061222 Minefield/3.0a2pre

The current bug number should be filled in in "to bugs" input box to simplify tagging.

Reproducible: Always

Steps to Reproduce:
1.login and view https://landfill.bugzilla.org/prodpatches/show_bug.cgi?id=415
2.examine the tagging interface at the bottom
3.

Actual Results:  
Tagging would be much simpler if the current bug number was filled in in the "to bugs" input box.
(Assignee)

Updated

12 years ago
Status: UNCONFIRMED → NEW
Ever confirmed: true
Target Milestone: --- → Bugzilla 3.0
Version: unspecified → 2.23.3
(Assignee)

Comment 1

12 years ago
Created attachment 249672 [details] [diff] [review]
patch - v1

Pre-fill the box with the bug's id if there is one.
Assignee: ui → reed
Status: NEW → ASSIGNED
Attachment #249672 - Flags: review?(bugzilla-mozilla)

Comment 2

12 years ago
Comment on attachment 249672 [details] [diff] [review]
patch - v1

>Index: template/en/default/global/per-bug-queries.html.tmpl

>-        <input type="text" name="bug_ids" size="12" maxlength="80">
>+        <input type="text" name="bug_ids" size="12" maxlength="80"
>+         [%- " value=\"$bug.bug_id\"" IF bug %]>

This assumes bug is only used by show_bug.cgi. It is also used by buglist.cgi (others as well). E.g. try buglist.cgi?bug_id=1,2 (or any search). The code will prefill the tag to '2'.

Think the best option is having a different variable.

Further, with show_bug.cgi?id=1&id=2&format=multiple it would be nice if it would prefill the list with "1,2" :-) (not a requirement.. having it work for a single bug is fine).
Attachment #249672 - Flags: review?(bugzilla-mozilla) → review-
(Assignee)

Comment 3

12 years ago
Created attachment 249722 [details] [diff] [review]
patch - v2

Use "bugids" as a var name and implement request.
Attachment #249672 - Attachment is obsolete: true
Attachment #249722 - Flags: review?(bugzilla-mozilla)

Comment 4

12 years ago
I don't like patch v2. The logic should be done in show_bug.cgi.
(Assignee)

Comment 5

12 years ago
Created attachment 249723 [details] [diff] [review]
patch - v3

Implement LpSolit's way.
Attachment #249722 - Attachment is obsolete: true
Attachment #249723 - Flags: review?(bugzilla-mozilla)
Attachment #249722 - Flags: review?(bugzilla-mozilla)

Comment 6

12 years ago
Comment on attachment 249723 [details] [diff] [review]
patch - v3

>Index: template/en/default/global/per-bug-queries.html.tmpl

>-        <input type="text" name="bug_ids" size="12" maxlength="80">
>+        <input type="text" name="bug_ids" size="12" maxlength="80"
>+         [%- " value=\"$bugids\"" IF bugids %]>

#   Failed test '(en/default) template/en/default/global/per-bug-queries.html.tmpl has unfiltered directives:
#   91:- " value=\"$bugids\"" IF bugids 
# --ERROR'
#   in t/008filter.t at line 131.
Attachment #249723 - Flags: review?(bugzilla-mozilla) → review-
(Assignee)

Comment 7

12 years ago
Created attachment 249725 [details] [diff] [review]
patch - v4

Add directive to filterexceptions.pl.
Attachment #249723 - Attachment is obsolete: true
Attachment #249725 - Flags: review?(bugzilla-mozilla)

Updated

12 years ago
Attachment #249725 - Flags: review?(bugzilla-mozilla) → review+

Updated

12 years ago
Flags: approval?

Updated

12 years ago
Severity: trivial → enhancement
Flags: approval? → approval+
(Assignee)

Comment 8

12 years ago
Checking in show_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/show_bug.cgi,v  <--  show_bug.cgi
new revision: 1.50; previous revision: 1.49
done
Checking in template/en/default/global/per-bug-queries.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/per-bug-queries.html.tmpl,v  <--  per-bug-queries.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--  filterexceptions.pl
new revision: 1.92; previous revision: 1.91
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.