364845 - ctrl-shift-pageup/down should move current tab left/right

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Tuukka Tolvanen (sp3000)]

ctrl-shift-pageup/down should move current tab left/right, like they do in e.g. gnome-terminal

Comment 1

[Micah Gersten]

Ubuntu Bug:
https://bugs.launchpad.net/bugs/192092

Duplicates:
Bug 423734
Bug 391084

Does not work in Firefox 3.5.

Comment 5

[Marius Gedminas]

Attachment: patch version 2

Version 2 of the patch, with style changes as requested by Gavin in comments of bug 702960.

Tested, works for me.

One thing I hadn't noticed before: moveTabForward/Backward leaves keyboard focus on the tab itself, which is something I didn't expect.  This explains why I had occasional difficulties scrolling web pages with Space or PgUp/PgDown lately -- keyboard focus was in the wrong place, and I didn't notice.  Any ideas how to avoid that focus change?

Comment 6

[Dão Gottwald [:dao]]

(In reply to Marius Gedminas from comment #5)
> One thing I hadn't noticed before: moveTabForward/Backward leaves keyboard
> focus on the tab itself, which is something I didn't expect.  This explains
> why I had occasional difficulties scrolling web pages with Space or
> PgUp/PgDown lately -- keyboard focus was in the wrong place, and I didn't
> notice.  Any ideas how to avoid that focus change?

You can remove the focus change from the moveTabBackward, moveTabForward, moveTabToStart and moveTabToEnd methods and do it directly in the keypress handler where needed.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

It looks like bug 822068 is also touching this code.

Comment 8

[ithinc]

So ctrl-shift-home/end should move current tab to start/end?

Comment 9

[ithinc]

Noticed that these key combinations have been used in Caret Browsing mode.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to ithinc from comment #9)
> Noticed that these key combinations have been used in Caret Browsing mode.

Do you have a pointer to the code?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 689087 [details] [diff] [review]
patch version 2

Code-wise, this looks good. I think the only suggestions I would make is that we should probably limit this behavior to Linux somehow (probably by using an #ifdef XP_GNOME like the one in browser-sets.inc).

I don't know the answers to ithinc's concerns, though (about the desired behavior for ctrl+shift+home/end, and possible conflict with other shortcuts) - we should sort that out before landing this.

Comment 12

[ithinc]

(In reply to :Gavin Sharp (use [e-mail] for email) from comment #10)
> (In reply to ithinc from comment #9)
> > Noticed that these key combinations have been used in Caret Browsing mode.
> 
> Do you have a pointer to the code?

I overlooked it. ctrl-shift-home/end are used but ctrl-shift-pageup/down not.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

OK, let's do this then!

Thanks again for the patch, Marius.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d16a92e1a41

Comment 15

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0d16a92e1a41

Comment 16

[Cornel Ionce [:noni] [Hubs QA]]

Working on Firefox Nightly.
User Agent: Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130129 Firefox/21.0
Build ID: 20130129030851.

Marking as verified fixed.

Comment 17

[ithinc]

I'm curious about why this was not implemented via xul overlay.

Comment 18

[Dão Gottwald [:dao]]

(In reply to ithinc from comment #17)
> I'm curious about why this was not implemented via xul overlay.

There's not a great chance that you'll get a reply here. Feel free to file a new bug and propose a patch.