364846 - make bugzilla use one stylesheet for all browsers

Status: RESOLVED WONTFIX

(Bugzilla :: User Interface, enhancement)

Description

[Peter van der Woude [:Peter6]]

in global.css

- #footer {BORDER-TOP: #ddd 1px solid; MARGIN-TOP: 5px; BACKGROUND: #edf2f2; WIDTH: 100%; BORDER-BOTTOM: #ddd 1px solid}

+ #footer {BORDER-TOP: #ddd 1px solid; MARGIN-TOP: 5px; BACKGROUND: #edf2f2; WIDTH: 100%; BORDER-BOTTOM: #ddd 1px solid; padding-top:10px; padding-bottom:10px; font-size:90%; padding-left:1ex}

  #footer FORM {DISPLAY: inline}
  #footer .btn {FONT-SIZE: 80%}
  #footer .txt {FONT-SIZE: 80%}
- #footer #useful-links {PADDING-RIGHT: 1ex; PADDING-LEFT: 1ex}
- #footer #links-actions {LIST-STYLE-TYPE: none}
- #footer #links-edit {LIST-STYLE-TYPE: none}
- #footer #links-saved {LIST-STYLE-TYPE: none}
- #footer #links-special {LIST-STYLE-TYPE: none}
- #footer .label {VERTICAL-ALIGN: top; WHITE-SPACE: nowrap}
- #footer .links {VERTICAL-ALIGN: top}

in the bugfile.htm

trash this part
<div id="footer">
  <div class="intro"></div>
   <ul id="useful-links">
    <li id="links-actions">
    <div class="label">Actions: </div>
    <ul class="links">
     <li><a href="./">Home</a></li>
     <li><span class="separator">| </span><a href="enter_bug.cgi">New</a></li>
     <li><span class="separator">| </span><a href="query.cgi">Search</a></li>
    <li class="form">
   <span class="separator">| </span>
    <form action="buglist.cgi" method="get"
        onsubmit="if (this.quicksearch.value == '')
                  { alert('Please enter one or more search terms first.');
                    return false; } return true;">
    <input class="txt" type="text" name="quicksearch">
    <input class="btn" type="submit" value="Find" id="find_bottom"></form></li>
    <li><span class="separator">| </span><a href="report.cgi">Reports</a></li>
    <li><span class="separator">| </span>
    <a href="request.cgi">Requests</a></li>
    <li><span class="separator">| </span><a href="createaccount.cgi">New&nbsp;Account</a></li>
    <li><span class="separator">| </span><a href="/prodpatches/show_bug.cgi?id=415&amp;GoAheadAndLogIn=1">Log&nbsp;In</a></li>
   </ul>
   </li>
  </ul>
 <div class="outro"></div>
</div>

and replace it by:

<div id="footer" style="padding-top:10px;padding-bottom:10px;font-size:90%;padding-left:1ex">
 Actions:&nbsp;
 <a href="https://landfill.bugzilla.org/prodpatches/">Home</a> 
 | <a href="https://landfill.bugzilla.org/prodpatches/enter_bug.cgi">New</a>
 | <a href="https://landfill.bugzilla.org/prodpatches/query.cgi">Search</a> 
 | <form onsubmit="if (this.quicksearch.value == '')&#10;{ alert('Please enter one or more search terms first.');&#10;return false; } return true;" action=buglist.cgi method=get>
    <input class="txt" name="quicksearch">
    <input class="btn" id="find_bottom" type="submit" value="Find">
   </form>
 | <a href="https://landfill.bugzilla.org/prodpatches/report.cgi">Reports</a> 
 | <a href="https://landfill.bugzilla.org/prodpatches/request.cgi">Requests</a> 
 | <a href="https://landfill.bugzilla.org/prodpatches/createaccount.cgi">New&nbsp;Account</a> 
 | <a href="https://landfill.bugzilla.org/prodpatches/show_bug.cgi?id=415&amp;GoAheadAndLogIn=1">Log&nbsp;In</a> 
</div>

and remove the 

    <!--[if IE]>
      
      <link href="skins/standard/IE-fixes.css"
            rel="stylesheet"
            type="text/css">
    <![endif]-->

and

      <!--[if IE]>
        
        <link href="skins/standard/IE-fixes.css"
              rel="stylesheet"
              title="Classic"
              type="text/css">
      <![endif]-->

from the top of the page

Comment 1

[Frédéric Buclin]

Peter, why not attaching a patch? This would make the review easier.

Comment 2

[Peter van der Woude [:Peter6]]

(In reply to comment #1)
> Peter, why not attaching a patch? This would make the review easier.
> 
Feel free to teach me ;-)

Comment 3

[Marc Schumann [:Wurblzap]]

You can create a patch file using the diff command
(diff -urN ../reference . > patchfile).

Your proposal not being a diff makes it difficult to find out what it changes. From looking at your change from this angle, I don't really understand what the benefit would be. Having a separate IE CSS file allows developers to work in a standards-compliant way, and then add IE specifics in a separate file. I think we want to keep this... I'm going to mark this WONTFIX unless there is some good reason not to.

Comment 4

[Frédéric Buclin]

(In reply to Marc Schumann [:Wurblzap] from comment #3)
> From looking at your change from this angle, I don't really
> understand what the benefit would be. Having a separate IE CSS file allows
> developers to work in a standards-compliant way, and then add IE specifics
> in a separate file. I think we want to keep this... I'm going to mark this
> WONTFIX unless there is some good reason not to.

I agree -> wontfix