Closed Bug 364858 Opened 18 years ago Closed 18 years ago

Add hook in user-error.html.tmpl for text after "auth_failure" message

Categories

(Bugzilla :: Bugzilla-General, defect)

2.23.3
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: reed, Assigned: reed)

References

Details

Attachments

(1 file, 2 obsolete files)

Following through with bug 179944, comment #5. BMO needs a hook for a special message after the "auth_failure" error.
Attached patch patch - v1 (obsolete) — Splinter Review
Add hook.
Assignee: general → reed
Status: NEW → ASSIGNED
Attachment #249548 - Flags: review?(justdave)
Attached patch patch - v2 (obsolete) — Splinter Review
Add all the args that auth_failure has to work with and add perldoc info on the hook.
Attachment #249548 - Attachment is obsolete: true
Attachment #249549 - Flags: review?(justdave)
Attachment #249548 - Flags: review?(justdave)
Attachment #249549 - Flags: review?(justdave) → review?(zach)
No longer blocks: 179944
Blocks: 179944
Comment on attachment 249549 [details] [diff] [review]
patch - v2

>+    [% Hook::process("auth_failure", { group => $group, reason => $reason, action => $action, object => $object }) %]

Obviously, "Hook::process" is supposed to be "Hook.process". That's already been corrected locally. :)
Comment on attachment 249549 [details] [diff] [review]
patch - v2

This is wrong.
Attachment #249549 - Attachment is obsolete: true
Attachment #249549 - Flags: review?(zach)
*** Bug 365052 has been marked as a duplicate of this bug. ***
Attached patch patch - v3Splinter Review
What I really needed the entire time. This is what is being used on bmo already.
Attachment #250826 - Flags: review?(myk)
Comment on attachment 250826 [details] [diff] [review]
patch - v3

Good stuff. r=gerv.

Gerv
Attachment #250826 - Flags: review?(myk) → review+
Flags: approval+
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v  <--  user-error.html.tmpl
new revision: 1.204; previous revision: 1.203
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: