Closed
Bug 365100
Opened 18 years ago
Closed 18 years ago
"Open in Tabs" doesn't work in the left pane of the organizer
Categories
(Firefox :: Bookmarks & History, defect, P2)
Firefox
Bookmarks & History
Tracking
()
RESOLVED
FIXED
Firefox 3 alpha2
People
(Reporter: asaf, Assigned: asaf)
References
Details
Attachments
(2 files)
5.41 KB,
patch
|
moco
:
review+
|
Details | Diff | Splinter Review |
696 bytes,
patch
|
Details | Diff | Splinter Review |
Places organizer: "Open in Tabs" doesn't work in the context menu of the left pane.
This happens because excludeItems is set to true for this view, and openLinksInTabs relies on the view state. Solution is to make openLinksInTabs call getFolderContents directly.
Assignee | ||
Comment 1•18 years ago
|
||
O(2n)->(On) while I'm at it.
Attachment #249753 -
Flags: review?(sspitzer)
Comment 2•18 years ago
|
||
Comment on attachment 249753 [details] [diff] [review]
patch
asaf, when I was in this code last, I was sure that I needed the "node.containerOpen" lines, otherwise I would not get any results if the container was closed.
how come that is not needed anymore?
Assignee | ||
Comment 3•18 years ago
|
||
(In reply to comment #2)
> (From update of attachment 249753 [details] [diff] [review])
> asaf, when I was in this code last, I was sure that I needed the
> "node.containerOpen" lines, otherwise I would not get any results if the
> container was closed.
>
> how come that is not needed anymore?
>
getFolderContents sets containerOpen.
Comment 4•18 years ago
|
||
Comment on attachment 249753 [details] [diff] [review]
patch
r=sspitzer, thanks for the explanation (here and in irc)
Attachment #249753 -
Flags: review?(sspitzer) → review+
Assignee | ||
Comment 5•18 years ago
|
||
mozilla/browser/components/places/content/controller.js 1.107
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Priority: -- → P2
Resolution: --- → FIXED
Assignee | ||
Comment 6•18 years ago
|
||
mozilla/browser/components/places/content/controller.js 1.108
Comment 7•15 years ago
|
||
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".
In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body contains places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.
Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.
Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•