365118 - [BEOS] nsXULElement fails to build, nsXULElement::mPrototype' is protected

Status: RESOLVED INCOMPLETE

(Core :: DOM: Core & HTML, defect)

Description

[tqh]

Bug 363450 caused BeOS builds to fail with
`class nsXULPrototypeAttribute * nsXULElement::FindPrototypeAttribute(int, nsIAtom *) const' is protected
`class nsRefPtr<nsXULPrototypeElement> nsXULElement::mPrototype' is protected

BeOS is unfortunatly stuck with gcc2.95.3, so it will probably need a little help to get past this. Suggestions on how to solve this?

Adding a verbose log, and a temporary patch which can be used for building on BeOS for now.

Comment 1

[tqh]

Attachment: BeOS build failure output

Comment 2

[tqh]

Attachment: Ugly patch to get past this temporarily

Comment 3

[tqh]

Attachment: Add friend to class nsScriptEvent..Tearoff

Comment 4

[tqh]

Is that solution ok?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

I think it is more common to have the friend class defined
in a bit different way.
http://lxr.mozilla.org/seamonkey/source/layout/base/nsPresShell.cpp#1062
So perhaps adding |friend class nsScriptEventHandlerOwnerTearoff;|
after |class nsScriptEventHandlerOwnerTearoff {...};|
Though, actually I don't know if there is any problem with the 
proposed patch. Haven't heard about any compiler bugs related to that.

Comment 6

[tqh]

Someone fixed it while I've been away. Thanks.

Comment 7

[tqh]

Hmm, I did a straight CVS-build and it didn't fail but now it does, so reopening.