[BEOS] nsXULElement fails to build, nsXULElement::mPrototype' is protected

RESOLVED INCOMPLETE

Status

()

defect
RESOLVED INCOMPLETE
13 years ago
a month ago

People

(Reporter: thesuckiestemail, Unassigned)

Tracking

({helpwanted})

Trunk
Other
BeOS
Points:
---
Bug Flags:
blocking1.9 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

13 years ago
Bug 363450 caused BeOS builds to fail with
`class nsXULPrototypeAttribute * nsXULElement::FindPrototypeAttribute(int, nsIAtom *) const' is protected
`class nsRefPtr<nsXULPrototypeElement> nsXULElement::mPrototype' is protected

BeOS is unfortunatly stuck with gcc2.95.3, so it will probably need a little help to get past this. Suggestions on how to solve this?

Adding a verbose log, and a temporary patch which can be used for building on BeOS for now.
(Reporter)

Comment 1

13 years ago
(Reporter)

Comment 2

13 years ago
(Reporter)

Updated

13 years ago
Keywords: helpwanted
(Reporter)

Comment 3

13 years ago
Attachment #249757 - Attachment is obsolete: true
(Reporter)

Comment 4

13 years ago
Is that solution ok?
Flags: blocking1.9?
I think it is more common to have the friend class defined
in a bit different way.
http://lxr.mozilla.org/seamonkey/source/layout/base/nsPresShell.cpp#1062
So perhaps adding |friend class nsScriptEventHandlerOwnerTearoff;|
after |class nsScriptEventHandlerOwnerTearoff {...};|
Though, actually I don't know if there is any problem with the 
proposed patch. Haven't heard about any compiler bugs related to that.
(Reporter)

Comment 6

12 years ago
Someone fixed it while I've been away. Thanks.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WORKSFORME
(Reporter)

Comment 7

12 years ago
Hmm, I did a straight CVS-build and it didn't fail but now it does, so reopening.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Flags: blocking1.9? → blocking1.9-
Assignee: general → nobody
QA Contact: ian → general
Status: REOPENED → RESOLVED
Last Resolved: 12 years ago2 years ago
Resolution: --- → INCOMPLETE
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.