365124 - "Named tags" searches should be on their own line in the footer

Status: RESOLVED WONTFIX

(Bugzilla :: User Interface, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

As named tags searches are different from real saved searches, they should get listed separately in the footer (similar to how other people's shared searches get their own line)

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

I'm not 100% happy with my patch, but I cannot think of anything better right now. If you use tags but have none defined yet, an empty line is added anyway.

Comment 2

[Olav Vitters]

Comment on attachment 249772 [details] [diff] [review]
patch, v1

>Index: template/en/default/global/useful-links.html.tmpl

I do not like that empty line. That should be removed. Suggest to do the following somewhere:
[% has_bug_ids_queries = 0 %]

>+        [%# First, display your own queries (excluding tags, a.k.a. list of bugs). %]
>         [% FOREACH q = user.queries %]

and here:
[% has_bug_ids_queries = 1 IF q.bug_ids_only %]

>@@ -131,6 +130,23 @@

>+    [%# If the user doesn't use tags, then he probably doesn't want to see
>+      # the existing ones anymore, if any. %]
>+    [% IF user.id && user.settings.per_bug_queries.value == "on" %]

Add the condition:
 && has_bug_ids_queries

However, I like the 'Tags:' addition (makes the purpose clearer). Think it is good if that appeared before the 'Add/Remove the named tag' even if there are no existing tags.

Comment 4

[Frédéric Buclin]

We no longer generate special saved searches for tags, so we no longer make any distinction between normal saved searches and what I called "lists of bugs".