365134 - Bindings might fire before all overlays have been applied

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[[e-mail]]

I first discovered this while trying to fix some cases of bug 346605.
Basically what we do is we overlay a bunch of <dialog>s so that their button attribute is (for example) "accept,cancel,help" instead of "accept,cancel".
However, this doesn't work for mailViewSetup.xul; now this dialog has a static overlay, searchTermOverlay.xul, with an accompanying script that calls document.getElementById from within the body of the script as part of its initialisation. For whatever reason this triggers binding attachment for the <dialog> element itself, which constructs the dialog with the old "accept,cancel" buttons. Only later are the attributes overwritten by SeaMonkey's helpMailOverlay.xul dynamic overlay.

I don't even know if this is a regression, but at least I can work around the problem by avoiding the call to document.getElementById.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Getting a node from script will wrap the node.  For XUL, this means wrapping all ancestors of the node too.  And wrapping a node constructs the XBL bindings, so that you can script them.

It's worked this way for about forever, and is a fundamental problem with the design of XBL and XUL (the latter because of the parenting thing).

Comment 2

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven't been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.