365189 - document.width/document.height flush layout too late

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Eli Friedman]

Testcase coming up; the issue is caused by the presshell being retrieved before the layout is flushed.

(Bug discovered through code inspection; I haven't seen anyone try this.)

Comment 1

[Eli Friedman]

Attachment: Patch

Fix + some cleanup. (I'm changing the behavior of the HTML calculation slightly, but I doubt anyone cares what the results are with overflow set on both the root element and the body.)

Comment 2

[Eli Friedman]

Comment on attachment 265501 [details] [diff] [review]
Patch

Not sure if you're the right person to ask for review, but you r+ed the last patch to this code.

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 265501 [details] [diff] [review]
Patch

This has too much layout specific stuff for me. Please ask one of the layout guys instead. I can sr though unless the reviewer r/sr it.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    nsresult rv = GetViewportSize(&width, &height);
+    *aHeight = height;

Why can't you just do "return GetViewportSize(&width, aHeight);" like you did in the other part of the patch?

Comment 5

[Eli Friedman]

Attachment: Patch v2

With more consistent style.

Comment 6

[Peter van der Woude [:Peter6]]

It looks like this may have caused Bug 381746

Comment 7

[Nickolay_Ponomarev]

(This was checked in at 2007-05-22 20:52.)

Should this be marked fixed?

Comment 8

[Eli Friedman]

Oh yeah, forgot to mark it.