365204 - xcodebuild -buildstyle flag is deprecated, should be -configuration

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ray Kiddy]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.1) Gecko/20061204 Firefox/2.0.0.1


With newer versions of Xcode, the -buildstyle flag is deprecated. One uses -configuration instead.

The Xcode 2.0 User Guide is wrong, but one can see the doc for this in:

http://developer.apple.com/documentation/DeveloperTools/Reference/XcodeBuildSettingRef/build_setting_ref/build_setting_ref.html


Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Ray Kiddy]

Attachment: patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 264961 [details] [diff] [review]
patch

Mark/josh, have we upgraded all the tinderboxes that were using XCode 1.x?

Comment 3

[Mark Mentovai]

Comment on attachment 264961 [details] [diff] [review]
patch

We can't do this until we deprecate 10.3.9 as a supported build platform - we don't have any 10.3 tinderboxen left, but we still do support Xcode 1.5 on 10.3.9 for other folks out there.

Comment 4

[Ray Kiddy]

It is not possible to have the build system determine that it should use one flag for Tiger et seq and one flag for Panther? This is surprising. If the build tools must be as dumb as the version from 5 years ago on the OS, then, well, is this true?

Comment 5

[Ray Kiddy]

http://wiki.mozilla.org/Mac:Build_Requirements

It might be useful if this page was updated. It does not mention Mac OS X 10.5 at all. But from what it says, it appears that trunk builds are only supported on 10.4 et seq.

So, that means this change could be checked in on the trunk, yes?

Comment 6

[Nomis101]

Attachment: My proposed patch for mozilla-central

Because on mozilla-central mozilla/embedding/tests/cocoaEmbed/Makefile.in doesn't exist anymore and mozilla/modules/plugin/samples/default/mac/Makefile.in is now in mozilla/modules/plugin/default/mac/, a new patch is needed.
This one is my proposal.

Comment 7

[Nomis101]

Trunk doesn't contain "-buildstyle" anymore, so I mark this as fixed.