Closed
Bug 365236
Opened 18 years ago
Closed 18 years ago
Implement font-size-adjust on Mac
Categories
(Core :: Graphics, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: masayuki, Assigned: masayuki)
References
(Depends on 1 open bug, )
Details
(Keywords: css2, fonts, intl)
Attachments
(1 file, 1 obsolete file)
7.63 KB,
patch
|
vlad
:
review+
|
Details | Diff | Splinter Review |
I'll attach the patch in Jan. 2007.
Assignee | ||
Comment 1•18 years ago
|
||
Attachment #250694 -
Flags: review?(vladimir)
Assignee | ||
Comment 2•18 years ago
|
||
updating to latest trunk. Vlad: This patch doesn't changes the font selection. This patch only changes the font size if font-size-adjust is not 'none'. Would you review it?
Attachment #250694 -
Attachment is obsolete: true
Attachment #253361 -
Flags: review?(vladimir)
Attachment #250694 -
Flags: review?(vladimir)
Comment 3•18 years ago
|
||
I tested this patch a bit. All of Hixies tests pass [1], except the last one [2]: I get a 3px by 3px square in Minefield Mac. Fx 2.0.0.1 Windows shows a 50px by 50px square, with a 10px border on my system. But I'm not sure that test is displayed correctly on FX 2.0.0.1 Windows either. [1] there is the problem with line-height, though (bug 366138). [2] http://www.hixie.ch/tests/adhoc/css/fonts/size-adjust/009.xml
Assignee | ||
Comment 4•18 years ago
|
||
(In reply to comment #3) > [2]: I get a 3px by 3px square in Minefield Mac. Fx 2.0.0.1 Windows shows a > 50px by 50px square, with a 10px border on my system. But I'm not sure that > test is displayed correctly on FX 2.0.0.1 Windows either. > > [2] http://www.hixie.ch/tests/adhoc/css/fonts/size-adjust/009.xml Thank you for your testing. It may be reproduced on Win and Linux too. I read the code for calculating the height/width. The nsFont is referenced in the calculating. But current thebes doesn't change the size of nsFont. So, we need to change it, but it's another bug.
Attachment #253361 -
Flags: review?(vladimir) → review+
Assignee | ||
Comment 5•18 years ago
|
||
checked-in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 6•18 years ago
|
||
Thanks, Masayuki. I filed bug 369083 for comment 3 and 4 (box width/height/border-width). ----------- Verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a2pre) Gecko/20070202 Minefield/3.0a2pre ID:2007020203 [cairo]
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•