I'll attach the patch in Jan. 2007.
12 years ago
Depends on: 366138
Created attachment 250694 [details] [diff] [review] Patch rv1.0
Created attachment 253361 [details] [diff] [review] Patch rv1.0.1 updating to latest trunk. Vlad: This patch doesn't changes the font selection. This patch only changes the font size if font-size-adjust is not 'none'. Would you review it?
I tested this patch a bit. All of Hixies tests pass , except the last one : I get a 3px by 3px square in Minefield Mac. Fx 18.104.22.168 Windows shows a 50px by 50px square, with a 10px border on my system. But I'm not sure that test is displayed correctly on FX 22.214.171.124 Windows either.  there is the problem with line-height, though (bug 366138).  http://www.hixie.ch/tests/adhoc/css/fonts/size-adjust/009.xml
(In reply to comment #3) > : I get a 3px by 3px square in Minefield Mac. Fx 126.96.36.199 Windows shows a > 50px by 50px square, with a 10px border on my system. But I'm not sure that > test is displayed correctly on FX 188.8.131.52 Windows either. > >  http://www.hixie.ch/tests/adhoc/css/fonts/size-adjust/009.xml Thank you for your testing. It may be reproduced on Win and Linux too. I read the code for calculating the height/width. The nsFont is referenced in the calculating. But current thebes doesn't change the size of nsFont. So, we need to change it, but it's another bug.
Attachment #253361 - Flags: review?(vladimir) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
Thanks, Masayuki. I filed bug 369083 for comment 3 and 4 (box width/height/border-width). ----------- Verified with Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a2pre) Gecko/20070202 Minefield/3.0a2pre ID:2007020203 [cairo]
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.