Closed
Bug 365241
Opened 19 years ago
Closed 19 years ago
Changing the context of a patch fails
Categories
(Bugzilla :: Attachments & Requests, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
()
Details
(Keywords: regression)
Attachments
(1 file)
|
891 bytes,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
When viewing a patch in the Diff mode, changing the context fails:
Software error:
Could not check out mozilla/webtools/bugzilla/template/en/default/admin/products/footer.html.tmpl r1.7 from :pserver:anonymous:anonymous@cvs-mirror.mozilla.org:/cvsroot at PatchReader/AddCVSContext.pm line 191.
Probably a problem due to mod_perl.
|
||
Updated•19 years ago
|
QA Contact: myk → reed
|
||
Comment 1•19 years ago
|
||
Interestingly enough, we found out that bmo wasn't running mod_perl until just now. So this is probably something else.
|
||
Comment 2•19 years ago
|
||
bmo's attachment code is unmodified from CVS, and the installed PatchReader package is the same one as on landfill.
Assignee: justdave → attach-and-request
Component: Bugzilla: Other b.m.o Issues → Attachments & Requests
Product: mozilla.org → Bugzilla
QA Contact: reed → default-qa
Target Milestone: --- → Bugzilla 3.0
Version: other → 2.23.3
|
|
Assignee | |
Comment 3•19 years ago
|
||
The problem is that PatchReader::CVSClient needs $::cvsbin to be a global variable. When we removed global variables to use Bugzilla->params->{'cvsbin'}, it stopped working correctly. This patch fixes the problem on a non mod_perl installation. I haven't tested on mod_perl, though.
Assignee: attach-and-request → LpSolit
Status: NEW → ASSIGNED
Attachment #249967 -
Flags: review?(mkanat)
|
|
||
Comment 4•19 years ago
|
||
Comment on attachment 249967 [details] [diff] [review]
patch, v1
Okay, that works fine for now. We really should get PatchReader fixed, because it really shouldn't rely on global variables.
Attachment #249967 -
Flags: review?(mkanat) → review+
|
|
Assignee | |
Updated•19 years ago
|
Flags: approval?
|
|
||
Updated•19 years ago
|
Flags: approval? → approval+
|
|
Assignee | |
Comment 5•19 years ago
|
||
Checking in Bugzilla/Attachment/PatchReader.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Attachment/PatchReader.pm,v <-- PatchReader.pm
new revision: 1.4; previous revision: 1.3
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•