365344 - crash reporter should save list of crash reports (pending and successfully submitted)

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[(not currently active) Ted Mielczarek]

Currently the crash reporter just attempts to submit a crash report when a crash happens.  It should save the crash report to a file in case it can't submit it at the present time, and be able to submit pending reports at a later date.  It should also save a list of submitted reports, as the current talkback client does.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: save list of crash reports

This patch does a few things:
1) Creates a folder to store info in: %APPDATA%\Vendor\Product\Crash Reports (on my system, for Firefox this works out to C:\Documents and Settings\Ted Mielczarek\Application Data\Mozilla\Firefox\Crash Reports)
2) Places new crash reports in that folder\pending
3) Stores the server response in that folder\submitted.  It creates a file named ${CRASH_ID}.txt, where ${CRASH_ID} comes from the server.  The server can also provide a ViewURL, which will be put into the file to point users to where they can view their crash report online.

I'm not going to worry about re-submitting failed crash reports right now.  We'll do that in a different bug.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: handle empty vendor

Handle an empty or missing Vendor string, since Thunderbird uses that.

Comment 3

[Benjamin Smedberg]

Comment on attachment 262554 [details] [diff] [review]
handle empty vendor

>Index: toolkit/airbag/client/crashreporter_win.cpp

>+bool MoveFile(const wstring& file, const wstring& toDir)

I can't figure out why you need this code. Unless you find a reason, please use the standards windows MoveFileW API.

Comment 4

[(not currently active) Ted Mielczarek]

Attachment: use win32's MoveFile

Yeah, no real reason there other than that Google failed me, and I forgot that that API existed.  This is what I'm checking in.

Comment 5

[(not currently active) Ted Mielczarek]

Checked in.  I punted resubmitting pending reports to bug 378528.