365363 - Return value for GetJSDValue ignored leading to death

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[James Ross]

Users can and will do anything, especially if it isn't what the instructions say; this is a simple case-in-point. If a non-jsdIValue is returned from the JS code of the execution hook, JSD's XPC wrapper goes up in flames after the indicated line because it didn't check the return value of it.

I'm out of trees, so you're out of luck on a patch for now, but it should be trivial.

Comment 1

[timeless]

Attachment: check for failures

i know that the current implementation of the service can't fail, but it is possible for these things to be shifted, and i'd rather play xpcom correct than have to chase crashes later :).

Comment 2

[James Ross]

Comment on attachment 251904 [details] [diff] [review]
check for failures

Looks good, r=silver.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 251904 [details] [diff] [review]
check for failures

So, I don't know this code, but I'm not sure that making InvalidateAll do nothing will lead to correct behaviour, but I guess without a context you can't do anything

Comment 4

[timeless]

Comment on attachment 251904 [details] [diff] [review]
check for failures

mozilla/js/jsd/jsd_xpc.cpp 	1.81