365385 - Unbreak undocumented keyboard shortcuts in profile manager

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Phil Ringnalda (:philor)]

While looking for something else, I noticed that there are two keyboard shortcuts when you have a profile selected in the profile manager: if you press 46, the profile isn't deleted because there's no function named confirmDelete, and if you press "VK_F2" you can rename the profile once you click the Rename Profile button, because otherwise you're not going to trigger the nonexistent function renameProfile. Then once you find RenameProfile(), we'll set the tooltiptext of an undefined element to the new name, and the path of an undefined profile.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

This fixes them, but I've got no idea how to do a unit test for it; it wouldn't break my heart if you just told me to rip the whole keyhandling bit out, though I'd still have no idea how to test for the correct tooltip applied to the correct profile after a rename.

Comment 2

[Benjamin Smedberg]

Comment on attachment 249977 [details] [diff] [review]
Fix v.1

You'd really have to write a functionality test, not a unit test.

Comment 3

[Phil Ringnalda (:philor)]

toolkit/profile/content/profileSelection.js 1.11