All users were logged out of Bugzilla on October 13th, 2018

Unbreak undocumented keyboard shortcuts in profile manager

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
10 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

12 years ago
While looking for something else, I noticed that there are two keyboard shortcuts when you have a profile selected in the profile manager: if you press 46, the profile isn't deleted because there's no function named confirmDelete, and if you press "VK_F2" you can rename the profile once you click the Rename Profile button, because otherwise you're not going to trigger the nonexistent function renameProfile. Then once you find RenameProfile(), we'll set the tooltiptext of an undefined element to the new name, and the path of an undefined profile.
(Assignee)

Comment 1

12 years ago
Created attachment 249977 [details] [diff] [review]
Fix v.1

This fixes them, but I've got no idea how to do a unit test for it; it wouldn't break my heart if you just told me to rip the whole keyhandling bit out, though I'd still have no idea how to test for the correct tooltip applied to the correct profile after a rename.
Attachment #249977 - Flags: first-review?(benjamin)

Comment 2

12 years ago
Comment on attachment 249977 [details] [diff] [review]
Fix v.1

You'd really have to write a functionality test, not a unit test.
Attachment #249977 - Flags: first-review?(benjamin) → first-review+
(Assignee)

Comment 3

12 years ago
toolkit/profile/content/profileSelection.js 1.11
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

10 years ago
Component: XRE Startup → Startup and Profile System
QA Contact: xre.startup → startup
You need to log in before you can comment on or make changes to this bug.