365394 - Address bar no longer focused when closing the last tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Simon Bünzli]

Regression due to the back-out in bug 348031.

Steps to reproduce:
1. Make the tab bar visible all the time
2. Close all open tabs through either Ctrl+W or the tabs' close buttons

Expected result:
A blank tab is shown and the address bar has the focus (as after creating a new tab).

Actual result:
The content area has the focus.

Comment 1

[Simon Bünzli]

Attachment: branch patch

Comment 2

[Jay Patel [:jay]]

Please get this patch reviewed and thoroughly tested before asking for approvals (to avoid repeating what happened in bug 348031).  Thanks!

Comment 3

[Asaf Romano (gone)]

Comment on attachment 249989 [details] [diff] [review]
branch patch

r=mano.

Comment 4

[Jay Patel [:jay]]

Simon: Do we need any input from beltzner or mconnor before landing this?  Please check with them before requesting branch patch approvals.  Thanks! 

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 249989 [details] [diff] [review]
branch patch

We should get this before freeze

Comment 6

[Simon Bünzli]

A reminder: please check this in as soon as it's approved (I won't be able to do so). And FWIW: this is just half the patch from bug 348031 which already got approval1.8.1.1+.

Comment 7

[Jay Patel [:jay]]

Comment on attachment 249989 [details] [diff] [review]
branch patch

Approved for 1.8 branch, a=jay for drivers.

mconnor:  Could you check this in for Simon?  Or find someone who can?  Thanks!

Comment 8

[Nickolay_Ponomarev]

browser/base/content/browser.js  1.479.2.216

I take it, this doesn't need a trunk checkin, so marking fixed.

Comment 9

[Carsten Book [:Tomcat]]

Verified fixed for 1.8.1.2 after tests with Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.2pre) Gecko/2007012803 BonEcho/2.0.0.2pre on Windows and Linux 

Comment 10

[Simon Bünzli]

(In reply to comment #9)
> Verified fixed

It seems that this bug hasn't been fixed at all: see bug 356581 comment #5.

I guess this is because the focus is immediately set back to the content area in tabbrowser::updateCurrentBrowser right after we focus the address bar. Delaying |gURLBar.focus();| slightly further - e.g. until after |gBrowser.removeCurrentTab();| should do the trick.

OTOH this still looks too fragile, so we might want a completely different fix. Leaving that to bug 356581 though...